Change from int64_t to jlong for mac build #29861
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow #6570 to run ./run_host_tests.sh for Mac Build, we saw error below: ```error: cannot initialize a parameter of type 'const facebook::jni::JPrimitiveArray<_jlongArray *>::T *' (aka 'const long *') with an rvalue of type 'std::__1::vector<long long, std::__1::allocator<long long> >::value_type *' (aka 'long long *') jTensorShape->setRegion(0, tensorShapeVec.size(), tensorShapeVec.data());``` Differential Revision: [D18519087](https://our.internmc.facebook.com/intern/diff/D18519087/) [ghstack-poisoned]
xcheng16
pushed a commit
that referenced
this pull request
Nov 15, 2019
Follow #6570 to run ./run_host_tests.sh for Mac Build, we saw error below: ```error: cannot initialize a parameter of type 'const facebook::jni::JPrimitiveArray<_jlongArray *>::T *' (aka 'const long *') with an rvalue of type 'std::__1::vector<long long, std::__1::allocator<long long> >::value_type *' (aka 'long long *') jTensorShape->setRegion(0, tensorShapeVec.size(), tensorShapeVec.data());``` Differential Revision: [D18519087](https://our.internmc.facebook.com/intern/diff/D18519087/) ghstack-source-id: 93961091 Pull Request resolved: #29861
Contributor
|
This pull request has been merged in 6dc8d72. |
csarofeen
pushed a commit
to mruberry/pytorch
that referenced
this pull request
Nov 18, 2019
Summary: Pull Request resolved: pytorch#29861 Follow pytorch#6570 to run ./run_host_tests.sh for Mac Build, we saw error below: ```error: cannot initialize a parameter of type 'const facebook::jni::JPrimitiveArray<_jlongArray *>::T *' (aka 'const long *') with an rvalue of type 'std::__1::vector<long long, std::__1::allocator<long long> >::value_type *' (aka 'long long *') jTensorShape->setRegion(0, tensorShapeVec.size(), tensorShapeVec.data());``` ghstack-source-id: 93961091 Test Plan: Run ./run_host_tests.sh and verify build succeed. Reviewed By: dreiss Differential Revision: D18519087 fbshipit-source-id: 869be12c82e6e0f64c878911dc12459defebf40b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Follow #6570 to run ./run_host_tests.sh for Mac Build, we saw error below: