[C++ API] Remove input_channels / output_channels / with_bias from ConvOptions #29838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yf225
requested review from
pbelevich
and removed request for
ebetica and
goldsborough
Member
CircleCI build failures summaryAs of commit 697fb71:
Here are the reasons each build failed:
This comment was automatically generated by Dr. CI. Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 4 time(s). |
pbelevich
approved these changes
Nov 14, 2019
Contributor
Author
|
Currently blocked by #29853. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 15, 2019
Summary: Update torchvision in CI to include pytorch/vision@44a5bae. This PR is blocking #29838. Pull Request resolved: #29853 Differential Revision: D18531096 Pulled By: yf225 fbshipit-source-id: 19ed7628d08854108a05e01696e09c9b03a3d5f4
yf225
force-pushed
the
cpp_remove_conv_options_deprecated_args
branch
from
697fb71 to
e97a59d
Compare
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
to pytorch/vision
that referenced
this pull request
Nov 16, 2019
…(#29838) Summary: Since torchvision is not using input_channels / output_channels / with_bias in ConvOptions anymore (#1576), we can remove the bridges now. Pull Request resolved: pytorch/pytorch#29838 Differential Revision: D18531481 Pulled By: yf225 fbshipit-source-id: e48d9e8cf110095f83d9ed18b9fec020ec725f3e
Contributor
csarofeen
pushed a commit
to mruberry/pytorch
that referenced
this pull request
Nov 18, 2019
Summary: Update torchvision in CI to include pytorch/vision@44a5bae. This PR is blocking pytorch#29838. Pull Request resolved: pytorch#29853 Differential Revision: D18531096 Pulled By: yf225 fbshipit-source-id: 19ed7628d08854108a05e01696e09c9b03a3d5f4
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since torchvision is not using input_channels / output_channels / with_bias in ConvOptions anymore (pytorch/vision#1576), we can remove the bridges now.