Check for mutable default parameters #29833
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
oncall: jit
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
driazati
approved these changes
Nov 14, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
csarofeen
pushed a commit
to mruberry/pytorch
that referenced
this pull request
Nov 18, 2019
Summary: Fix for pytorch#21545 We we were silently giving wrong semantics previously: Python behavior: ``` def test(x=[]): x.append(1) return len(x) print(test()) # 1 print(test()) # 2 ``` By checking at the python layer, we prevent any new models from serializing this behavior but do not break existing serialized models. Pull Request resolved: pytorch#29833 Differential Revision: D18513168 Pulled By: eellison fbshipit-source-id: 6fe73f28e1f9d39dedeaf67a04718089d14401a1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #21545
We we were silently giving wrong semantics previously:
Python behavior:
By checking at the python layer, we prevent any new models from serializing this behavior but do not break existing serialized models.