Re-unify module and interface in ConcreteModuleType #29825
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We made `ModuleInfo` a union initially to represent the idea that a submodule could either be a regular module or a module interface. This PR represents module interfaces as a ConcreteModuleType with no info (e.g. no "sugaredness"), and with the interface type as the underlying `jitType_`. This has the effect of reducing the special casing around adding/maintaining module info.
This was referenced Nov 14, 2019
Member
Author
|
cc @wanchaol |
facebook-github-bot
added
the
oncall: jit
Member
CircleCI build failures summaryAs of commit 496e993:
Here are the reasons each build failed:
This comment was automatically generated by Dr. CI. Please report bugs/suggestions on the GitHub issue tracker. |
wanchaol
approved these changes
Nov 14, 2019
Collaborator
wanchaol
left a comment
wanchaol
left a comment
There was a problem hiding this comment.
looks nice! one minor comment.
We made `ModuleInfo` a union initially to represent the idea that a submodule could either be a regular module or a module interface. This PR represents module interfaces as a ConcreteModuleType with no info (e.g. no "sugaredness"), and with the interface type as the underlying `jitType_`. This has the effect of reducing the special casing around adding/maintaining module info.
zdevito
approved these changes
Nov 19, 2019
| const auto& selfType = concreteType_->getJitType(); | ||
| const auto& selfType_ = concreteType_->getJitType(); | ||
| if (selfType_->cast<InterfaceType>()) { | ||
| return std::make_shared<SimpleValue>(self_)->attr(loc, m, field); |
Contributor
There was a problem hiding this comment.
SimpleValue(self)-> since we are deleting the object directly after.
Member
Author
There was a problem hiding this comment.
Changing it would cause a lint error internally: https://fburl.com/wiki/jshlq9g3. Which doesn't apply in this situation but I guess could conceivably happen with some more code mutations down the road, so we might as well follow the rule?
| return std::make_shared<SimpleValue>(self_)->attr(loc, m, field); | ||
| // ...otherwise, methods, parameters, attributes, and buffers are all | ||
| // first class so they get returned as SimpleValues | ||
| return std::make_shared<SimpleValue>(self_)->attr(loc, m, field); |
We made `ModuleInfo` a union initially to represent the idea that a submodule could either be a regular module or a module interface. This PR represents module interfaces as a ConcreteModuleType with no info (e.g. no "sugaredness"), and with the interface type as the underlying `jitType_`. This has the effect of reducing the special casing around adding/maintaining module info. Differential Revision: [D18575011](https://our.internmc.facebook.com/intern/diff/D18575011)
We made `ModuleInfo` a union initially to represent the idea that a submodule could either be a regular module or a module interface. This PR represents module interfaces as a ConcreteModuleType with no info (e.g. no "sugaredness"), and with the interface type as the underlying `jitType_`. This has the effect of reducing the special casing around adding/maintaining module info. Differential Revision: [D18575011](https://our.internmc.facebook.com/intern/diff/D18575011)
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
We made
ModuleInfoa union initially to represent the idea that asubmodule could either be a regular module or a module interface.
This PR represents module interfaces as a ConcreteModuleType with no
info (e.g. no "sugaredness"), and with the interface type as the
underlying
jitType_. This has the effect of reducing the specialcasing around adding/maintaining module info.
Differential Revision: D18575011