Add nn.quantized.Conv3d #29813
Closed
Add nn.quantized.Conv3d #29813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D18467749 |
Contributor
Author
|
Link to #28480 |
Member
|
Thanks for working on this. Overall it looks good. Check the OSS lint issues such as |
xiaomengy
force-pushed
the
export-D18467749
branch
from
77c2f7e to
e7da65e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D18467749 |
xiaomengy
force-pushed
the
export-D18467749
branch
from
e7da65e to
889da0d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D18467749 |
xiaomengy
force-pushed
the
export-D18467749
branch
from
889da0d to
6474b6f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D18467749 |
Contributor
Author
Done |
houseroad
reviewed
Nov 15, 2019
houseroad
reviewed
Nov 15, 2019
test/test_quantized_nn_mods.py
Outdated
Member
There was a problem hiding this comment.
input_feature_map_size => in_feature_map_size?
Summary: Pull Request resolved: pytorch#29813 Add nn.quantized.Conv3d Test Plan: buck test mode/dev-nosan //caffe2/test:quantized -- "conv" Reviewed By: jianyuh Differential Revision: D18467749 fbshipit-source-id: 3f992de8f4100f3bd7ba696a6e8943d027d8b2f8
xiaomengy
force-pushed
the
export-D18467749
branch
from
6474b6f to
037f245
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D18467749 |
Contributor
|
This pull request has been merged in 510ef4b. |
csarofeen
pushed a commit
to mruberry/pytorch
that referenced
this pull request
Nov 18, 2019
Summary: Pull Request resolved: pytorch#29813 Add nn.quantized.Conv3d Test Plan: buck test mode/dev-nosan //caffe2/test:quantized -- "conv" Reviewed By: jianyuh Differential Revision: D18467749 fbshipit-source-id: 892f708179e9e836ad902851ac1838847009da15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add nn.quantized.Conv3d
Test Plan: buck test mode/dev-nosan //caffe2/test:quantized -- "conv"
Reviewed By: jianyuh
Differential Revision: D18467749