Ensure initializedContextIds_ map is cleaned up appropriately in DistEngine. #29787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Engine. The initializedContextIds_ map was never cleaned up in DistEngine and kept on growing as we continue to run backward passes. To fix this, in this PR we ensure that the context id is cleaned up from this map once we are done with the backward pass. Closes #29083 Differential Revision: [D18498937](https://our.internmc.facebook.com/intern/diff/D18498937/) [ghstack-poisoned]
pritamdamania87
pushed a commit
that referenced
this pull request
Nov 14, 2019
…Engine. The initializedContextIds_ map was never cleaned up in DistEngine and kept on growing as we continue to run backward passes. To fix this, in this PR we ensure that the context id is cleaned up from this map once we are done with the backward pass. Closes #29083 Differential Revision: [D18498937](https://our.internmc.facebook.com/intern/diff/D18498937/) ghstack-source-id: 93889304 Pull Request resolved: #29787
pietern
reviewed
Nov 14, 2019
Contributor
pietern
left a comment
pietern
left a comment
There was a problem hiding this comment.
Not a fan of including the gtest header...
Otherwise the change LGTM.
| @@ -1,5 +1,6 @@ | |||
| #pragma once | |||
|
|
|||
| #include <gtest/gtest_prod.h> | |||
Contributor
There was a problem hiding this comment.
I don't like this... I know it's for making protected functions testable, but isn't there another way to achieve the same? For example, do the functions you're calling into need to be protected?
…ely in DistEngine." The initializedContextIds_ map was never cleaned up in DistEngine and kept on growing as we continue to run backward passes. To fix this, in this PR we ensure that the context id is cleaned up from this map once we are done with the backward pass. Closes #29083 Differential Revision: [D18498937](https://our.internmc.facebook.com/intern/diff/D18498937/) [ghstack-poisoned]
pritamdamania87
pushed a commit
that referenced
this pull request
Nov 14, 2019
…Engine. Pull Request resolved: #29787 The initializedContextIds_ map was never cleaned up in DistEngine and kept on growing as we continue to run backward passes. To fix this, in this PR we ensure that the context id is cleaned up from this map once we are done with the backward pass. Closes #29083 ghstack-source-id: 93947857 Differential Revision: [D18498937](https://our.internmc.facebook.com/intern/diff/D18498937/)
mrshenli
reviewed
Nov 18, 2019
|
|
||
| // Mark the autograd context id as initialized and unlock. | ||
| initializedContextIds_.insert(autogradContext.contextId()); | ||
| ClearContextIdGuard guard(autogradContext.contextId()); |
Contributor
There was a problem hiding this comment.
why this needs to be before the unlock?
mrshenli
approved these changes
Nov 18, 2019
Contributor
mrshenli
left a comment
mrshenli
left a comment
There was a problem hiding this comment.
This LGTM, just a minor comment on where to create the guard.
…ely in DistEngine." The initializedContextIds_ map was never cleaned up in DistEngine and kept on growing as we continue to run backward passes. To fix this, in this PR we ensure that the context id is cleaned up from this map once we are done with the backward pass. Closes #29083 Differential Revision: [D18498937](https://our.internmc.facebook.com/intern/diff/D18498937/) [ghstack-poisoned]
pritamdamania87
pushed a commit
that referenced
this pull request
Nov 19, 2019
…Engine. Pull Request resolved: #29787 The initializedContextIds_ map was never cleaned up in DistEngine and kept on growing as we continue to run backward passes. To fix this, in this PR we ensure that the context id is cleaned up from this map once we are done with the backward pass. Closes #29083 ghstack-source-id: 94161770 Differential Revision: [D18498937](https://our.internmc.facebook.com/intern/diff/D18498937/)
Contributor
|
This pull request has been merged in 63f4b60. |
1 similar comment
Contributor
|
This pull request has been merged in 63f4b60. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
The initializedContextIds_ map was never cleaned up in DistEngine and
kept on growing as we continue to run backward passes. To fix this, in this PR
we ensure that the context id is cleaned up from this map once we are done with
the backward pass.
Closes #29083
Differential Revision: D18498937