Also update the legacy API to support Packed Sequence support for quantized LSTM #29786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntized LSTM As Title says. This is a follow-up for #29585. Check #27963 Differential Revision: [D18497319](https://our.internmc.facebook.com/intern/diff/D18497319/) [ghstack-poisoned]
facebook-github-bot
added
the
oncall: jit
jianyuh
added a commit
that referenced
this pull request
Nov 14, 2019
…ntized LSTM As Title says. This is a follow-up for #29585. Check #27963 Differential Revision: [D18497319](https://our.internmc.facebook.com/intern/diff/D18497319/) ghstack-source-id: 93883524 Pull Request resolved: #29786
jamesr66a
approved these changes
Nov 14, 2019
Collaborator
jamesr66a
left a comment
jamesr66a
left a comment
There was a problem hiding this comment.
Code is fine, but wouldn't we want to encourage people to use the new API rather than adding features to the old one?
Member
Author
|
Agreed. Will keep the code un-merged here and see if the user has the request to only use the legacy API. |
Collaborator
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
As Title says. This is a follow-up for #29585. Check #27963
Differential Revision: D18497319