Skip to content

[android][gradle] Gradle build offline dependencies #2 #29738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
IvanKobzarev wants to merge 1 commit into from
Closed

[android][gradle] Gradle build offline dependencies #2 #29738

IvanKobzarev wants to merge 1 commit into from

Conversation

@IvanKobzarev
Copy link
Contributor

@IvanKobzarev IvanKobzarev commented Nov 13, 2019 •
edited
Loading

Original issue: #29159

The issue with previous reverted PR was that after phabricator's lint error about double quotes I changed:
$GRADLE_PATH $GRADLE_PARAMS -> "$GRADLE_PATH" "$GRADLE_PARAMS"
which ended in error:

Nov 13 17:16:38 + /opt/gradle/gradle-4.10.3/bin/gradle '-p android assembleRelease --debug --stacktrace --offline'
Nov 13 17:16:40 Starting a Gradle Daemon (subsequent builds will be faster)
Nov 13 17:16:41 
Nov 13 17:16:41 FAILURE: Build failed with an exception.
Nov 13 17:16:41 
Nov 13 17:16:41 * What went wrong:
Nov 13 17:16:41 The specified project directory '/var/lib/jenkins/workspace/ android assembleRelease --debug --stacktrace --offline' does not exist.

@IvanKobzarev IvanKobzarev force-pushed the ik_android_circleci_gradle_offline_build_fix branch from e5d1783 to 3d0c292 Compare November 13, 2019 19:07
@IvanKobzarev IvanKobzarev requested a review from ezyang November 13, 2019 20:50
facebook-github-bot
facebook-github-bot reviewed Nov 13, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IvanKobzarev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Nov 13, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IvanKobzarev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Nov 13, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IvanKobzarev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 13, 2019

@IvanKobzarev merged this pull request in 71aacf7.

@IvanKobzarev IvanKobzarev mentioned this pull request Nov 14, 2019
Closed
@facebook-github-bot facebook-github-bot deleted the ik_android_circleci_gradle_offline_build_fix branch July 13, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@IvanKobzarev @facebook-github-bot @ezyang @mruberry