Skip to content

C++ API: torch::nn::ConvTranspose{1,2,3}d #29721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nuka137 wants to merge 18 commits into from
Closed

C++ API: torch::nn::ConvTranspose{1,2,3}d #29721

nuka137 wants to merge 18 commits into from

Conversation

@nuka137
Copy link
Contributor

@nuka137 nuka137 commented Nov 13, 2019 •
edited by yf225
Loading

Add torch::nn::ConvTranspose{1,2,3}d module and functional support for the C++ API.

Related Issue: #25883

Reviewer: @yf225

@nuka137
Copy link
Contributor Author

nuka137 commented Nov 13, 2019

@yf225

Sorry for the late development about ConvTranspose API.
I made a PR, but I don't have a confidence about this patch in some points.
Could you check below things?

  • Is _ConvTransposeMixin class still needed in C++ API?
    • I added _output_padding method to ConvTransposeImplBase class, but it is not same design as Python API.
  • Should _ConvNd be a base class of ConvTranspose1d?
    • I used ConvTransposeImplBase class for the base class of ConvTranspose1dImpl

@yf225 yf225 changed the title C++ API: torch::nn::ConvTranspose1d C++ API: torch::nn::ConvTranspose{1,2,3}d Nov 17, 2019
@yf225 yf225 mentioned this pull request Nov 17, 2019
Open
yf225
yf225 approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@yf225 yf225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nuka137 Thanks a lot for the awesome work!

facebook-github-bot
facebook-github-bot reviewed Nov 19, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Nov 19, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Nov 19, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 20, 2019

@yf225 merged this pull request in a75b669.

@yf225 yf225 added the module: cpp Related to C++ API label Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@yf225 yf225 yf225 approved these changes

@ebetica ebetica Awaiting requested review from ebetica

@goldsborough goldsborough Awaiting requested review from goldsborough

Assignees

No one assigned

Labels

Merged module: cpp Related to C++ API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nuka137 @facebook-github-bot @yf225 @mruberry