[JIT] Only print original SourceRange on highlight #29708
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
facebook-github-bot
added
the
oncall: jit
zdevito
approved these changes
Nov 13, 2019
Contributor
zdevito
left a comment
zdevito
left a comment
There was a problem hiding this comment.
I think we should still print both, until we print full stack traces, but we should make the orig_source_range print first.
Differential Revision: [D18472089](https://our.internmc.facebook.com/intern/diff/D18472089) [ghstack-poisoned]
Differential Revision: [D18472089](https://our.internmc.facebook.com/intern/diff/D18472089) [ghstack-poisoned]
Differential Revision: [D18472089](https://our.internmc.facebook.com/intern/diff/D18472089) [ghstack-poisoned]
Differential Revision: [D18472089](https://our.internmc.facebook.com/intern/diff/D18472089) [ghstack-poisoned]
Contributor
|
@jamesr66a merged this pull request in 8d23f7a. |
csarofeen
pushed a commit
to mruberry/pytorch
that referenced
this pull request
Nov 18, 2019
Summary: Pull Request resolved: pytorch#29708 Test Plan: Imported from OSS Differential Revision: D18472089 Pulled By: jamesr66a fbshipit-source-id: 89cbe8edf4e3c90d3795a1f3ea55cb234e2682e0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D18472089