Use F::*FuncOptions for embedding/embeddingbag functionals #29673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 12, 2019
Use F::*FuncOptions for embedding/embeddingbag functionals gh-metadata: pytorch pytorch 29673 gh/yf225/68/head
Member
CircleCI build failures summaryAs of commit ad3ce4f:
Here are the reasons each build failed:
This comment was automatically generated by Dr. CI. Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 10 time(s). |
Use F::*FuncOptions for embedding/embeddingbag functionals gh-metadata: pytorch pytorch 29673 gh/yf225/68/head
pbelevich
approved these changes
Nov 14, 2019
Contributor
csarofeen
pushed a commit
to mruberry/pytorch
that referenced
this pull request
Nov 18, 2019
…9673) Summary: Pull Request resolved: pytorch#29673 Following pytorch#29364 and pytorch#29404, this PR makes `F::EmbeddingFuncOptions` and `F::EmbeddingBagFuncOptions` separate classes from `torch::nn::EmbeddingOptions` and `torch::nn::EmbeddingBagOptions`, so that it's easier to enforce that arguments such as `num_embeddings` and `embedding_dim` are required for `torch::nn::EmbeddingOptions` and `torch::nn::EmbeddingBagOptions`. Test Plan: Imported from OSS Differential Revision: D18462540 Pulled By: yf225 fbshipit-source-id: f2abf431e48675b0a9d7f6f398cdb90ff9037c35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Following #29364 and #29404, this PR makes
F::EmbeddingFuncOptionsandF::EmbeddingBagFuncOptionsseparate classes fromtorch::nn::EmbeddingOptionsandtorch::nn::EmbeddingBagOptions, so that it's easier to enforce that arguments such asnum_embeddingsandembedding_dimare required fortorch::nn::EmbeddingOptionsandtorch::nn::EmbeddingBagOptions.Differential Revision: D18462540