Allow rpc.remote to create RRef on self #29634
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation supports rpc.remote to self by doing the following steps: 1. create an owner RRef 2. add the owner RRef to owners_ in RRefContext, and keep it alive by using RRefId as the ForkId. 3. Go through serde and insert the message to the caller's thread-pool 4. When the response message gets processed, remove the itself from RRef fork map. [ghstack-poisoned]
mrshenli
added a commit
that referenced
this pull request
Nov 12, 2019
This implementation supports rpc.remote to self by doing the following steps: 1. create an owner RRef 2. add the owner RRef to owners_ in RRefContext, and keep it alive by using RRefId as the ForkId. 3. Go through serde and insert the message to the caller's thread-pool 4. When the response message gets processed, remove the itself from RRef fork map. ghstack-source-id: 059f92c Pull Request resolved: #29634
This implementation supports rpc.remote to self by doing the following steps: 1. create an owner RRef 2. add the owner RRef to owners_ in RRefContext, and keep it alive by using RRefId as the ForkId. 3. Go through serde and insert the message to the caller's thread-pool 4. When the response message gets processed, remove the itself from RRef fork map. Differential Revision: [D18445812](https://our.internmc.facebook.com/intern/diff/D18445812) [ghstack-poisoned]
mrshenli
added a commit
that referenced
this pull request
Nov 12, 2019
This implementation supports rpc.remote to self by doing the following steps: 1. create an owner RRef 2. add the owner RRef to owners_ in RRefContext, and keep it alive by using RRefId as the ForkId. 3. Go through serde and insert the message to the caller's thread-pool 4. When the response message gets processed, remove the itself from RRef fork map. ghstack-source-id: b82716e Pull Request resolved: #29634
This implementation supports rpc.remote to self by doing the following steps: 1. create an owner RRef 2. add the owner RRef to owners_ in RRefContext, and keep it alive by using RRefId as the ForkId. 3. Go through serde and insert the message to the caller's thread-pool 4. When the response message gets processed, remove the itself from RRef fork map. Differential Revision: [D18445812](https://our.internmc.facebook.com/intern/diff/D18445812) [ghstack-poisoned]
mrshenli
added a commit
that referenced
this pull request
Nov 12, 2019
This implementation supports rpc.remote to self by doing the following steps: 1. create an owner RRef 2. add the owner RRef to owners_ in RRefContext, and keep it alive by using RRefId as the ForkId. 3. Go through serde and insert the message to the caller's thread-pool 4. When the response message gets processed, remove the itself from RRef fork map. ghstack-source-id: af17a12 Pull Request resolved: #29634
This implementation supports rpc.remote to self by doing the following steps: 1. create an owner RRef 2. add the owner RRef to owners_ in RRefContext, and keep it alive by using RRefId as the ForkId. 3. Go through serde and insert the message to the caller's thread-pool 4. When the response message gets processed, remove the itself from RRef fork map. Differential Revision: [D18445812](https://our.internmc.facebook.com/intern/diff/D18445812) [ghstack-poisoned]
This was referenced Nov 13, 2019
aazzolini
reviewed
Nov 13, 2019
This implementation supports rpc.remote to self by doing the following steps: 1. create an owner RRef 2. add the owner RRef to owners_ in RRefContext, and keep it alive by using RRefId as the ForkId. 3. Go through serde and insert the message to the caller's thread-pool 4. When the response message gets processed, remove the itself from RRef fork map. Differential Revision: [D18445812](https://our.internmc.facebook.com/intern/diff/D18445812) [ghstack-poisoned]
This implementation supports rpc.remote to self by doing the following steps: 1. create an owner RRef 2. add the owner RRef to owners_ in RRefContext, and keep it alive by using RRefId as the ForkId. 3. Go through serde and insert the message to the caller's thread-pool 4. When the response message gets processed, remove the itself from RRef fork map. Differential Revision: [D18445812](https://our.internmc.facebook.com/intern/diff/D18445812) [ghstack-poisoned]
aazzolini
approved these changes
Nov 14, 2019
Contributor
aazzolini
left a comment
aazzolini
left a comment
There was a problem hiding this comment.
Looks good. In the future we should probably bypass serialization and deserialization and simply short-circuit the local call, but that will require access to the thread pool.
This implementation supports rpc.remote to self by doing the following steps: 1. create an owner RRef 2. add the owner RRef to owners_ in RRefContext, and keep it alive by using RRefId as the ForkId. 3. Go through serde and insert the message to the caller's thread-pool 4. When the response message gets processed, remove the itself from RRef fork map. Differential Revision: [D18445812](https://our.internmc.facebook.com/intern/diff/D18445812) [ghstack-poisoned]
This implementation supports rpc.remote to self by doing the following steps: 1. create an owner RRef 2. add the owner RRef to owners_ in RRefContext, and keep it alive by using RRefId as the ForkId. 3. Go through serde and insert the message to the caller's thread-pool 4. When the response message gets processed, remove the itself from RRef fork map. Differential Revision: [D18445812](https://our.internmc.facebook.com/intern/diff/D18445812) [ghstack-poisoned]
Contributor
csarofeen
pushed a commit
to mruberry/pytorch
that referenced
this pull request
Nov 18, 2019
Summary: Pull Request resolved: pytorch#29634 This implementation supports rpc.remote to self by doing the following steps: 1. create an owner RRef 2. add the owner RRef to owners_ in RRefContext, and keep it alive by using RRefId as the ForkId. 3. Go through serde and insert the message to the caller's thread-pool 4. When the response message gets processed, remove the itself from RRef fork map. Test Plan: Imported from OSS Differential Revision: D18445812 Pulled By: mrshenli fbshipit-source-id: e3b9aa98962c388acbc2ce294101a236d5cb2da6
xxtEchjovs44
pushed a commit
to xxtEchjovs44/pytorch
that referenced
this pull request
Jan 29, 2020
This implementation supports rpc.remote to self by doing the following steps: 1. create an owner RRef 2. add the owner RRef to owners_ in RRefContext, and keep it alive by using RRefId as the ForkId. 3. Go through serde and insert the message to the caller's thread-pool 4. When the response message gets processed, remove the itself from RRef fork map. ghstack-source-id: 582163d Pull Request resolved: pytorch/pytorch#29634
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This implementation supports rpc.remote to self by doing the
following steps:
by using RRefId as the ForkId.
RRef fork map.
Differential Revision: D18445812