Change arg dtype from float to double in LPPool and nn/utils/clip_grad.h #29584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 11, 2019
yf225
requested review from
pbelevich
and removed request for
ebetica and
goldsborough
Member
CircleCI build failures summaryAs of commit 0a08ecd:
Here are the reasons each build failed. This comment was automatically generated by Dr. CI. Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 6 time(s). |
pbelevich
approved these changes
Nov 12, 2019
…ls/clip_grad.h" Change arg dtype from float to double in LPPool and nn/utils/clip_grad.h gh-metadata: pytorch pytorch 29584 gh/yf225/62/head
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
In Python,
floatdtype is always 64-bit (https://stackoverflow.com/a/8216110), and the C++ equivalent APIs should takedoubledtype to match the bit length.Differential Revision: D18436616