Skip to content

Improve ConcreteModuleType::dump() #29582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
suo wants to merge 1 commit into from
Closed

Improve ConcreteModuleType::dump() #29582

suo wants to merge 1 commit into from

Conversation

@suo
Copy link
Member

@suo suo commented Nov 11, 2019 •
edited
Loading

Stack from ghstack:

Give it more info, fix a segfault

Differential Revision: D18435950

@suo
Improve ConcreteModuleType::dump()
a41bd83 
Give it more info, fix a segfault
@suo suo requested a review from apaszke as a code owner November 11, 2019 21:32
@suo suo mentioned this pull request Nov 11, 2019
Closed
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Nov 11, 2019
@ZolotukhinM ZolotukhinM self-requested a review November 11, 2019 21:46
ZolotukhinM
ZolotukhinM approved these changes Nov 11, 2019
View reviewed changes
Copy link

@ZolotukhinM ZolotukhinM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kostmo
Copy link
Member

kostmo commented Nov 11, 2019

CircleCI build failures summary

As of commit a41bd83:

  • 1/1 failures introduced in this PR
  • 0/1 recognized as flaky

Here are the reasons each build failed.

This comment was automatically generated by Dr. CI.
Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 12, 2019

@suo merged this pull request in 1a9e5da.

@facebook-github-bot facebook-github-bot deleted the gh/suo/221/head branch November 15, 2019 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apaszke apaszke Awaiting requested review from apaszke

1 more reviewer

@ZolotukhinM ZolotukhinM ZolotukhinM approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@suo @kostmo @facebook-github-bot @ZolotukhinM @mruberry