[jit] remove _register_* bindings from python #29499
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes how DataParallel and trace module creation works so that we no longer need to mutate Module class after it has been created. The only remaining usage of register_* functions are now inside C++ tests.
facebook-github-bot
added
the
oncall: jit
Member
CircleCI build failures summaryAs of commit b1dc203:
Here are the reasons each build failed. This comment was automatically generated by Dr. CI. Please report bugs/suggestions on the GitHub issue tracker. |
[jit] remove _register_* bindings from python This changes how DataParallel and trace module creation works so that we no longer need to mutate Module class after it has been created. The only remaining usage of register_* functions are now inside C++ tests. gh-metadata: pytorch pytorch 29499 gh/zdevito/133/head
suo
approved these changes
Nov 11, 2019
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This changes how DataParallel and trace module creation works so that
we no longer need to mutate Module class after it has been created.
The only remaining usage of register_* functions are now inside C++
tests.
Differential Revision: D18413652