[quant][graphmode] Returning axis from calculate_qparams #29494
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: `calculate_qparams` of per channel quantization should return the axis, this PR added this and also added corresponding support in graph mode Test Plan: python test/test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Nov 9, 2019
Closed
facebook-github-bot
added
the
oncall: jit
Summary: `calculate_qparams` of per channel quantization should return the axis, this PR added this and also added corresponding support in graph mode Test Plan: python test/test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
raghuramank100
approved these changes
Nov 13, 2019
Summary: `calculate_qparams` of per channel quantization should return the axis, this PR added this and also added corresponding support in graph mode Test Plan: python test/test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: `calculate_qparams` of per channel quantization should return the axis, this PR added this and also added corresponding support in graph mode Test Plan: python test/test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: `calculate_qparams` of per channel quantization should return the axis, this PR added this and also added corresponding support in graph mode Test Plan: python test/test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
ZolotukhinM
reviewed
Nov 14, 2019
| zero_point_val = g->insertConstant(zero_point); | ||
| // TODO: get axis from qparam | ||
| axis_val = g->insertConstant(0); | ||
| int axis = tp->elements()[2].toInt(); |
There was a problem hiding this comment.
This should be squashed with the change where it was introduced before landing. There is no reason to commit half-finished stuff.
Contributor
Author
There was a problem hiding this comment.
this is just because the order we do things right now, at the place we introduce this, calculate_qparam doesn't return axis and in this PR we added this support, so we can get the axis here.
There was a problem hiding this comment.
Ok, I reread everything more carefully and it makes sense.
Summary: `calculate_qparams` of per channel quantization should return the axis, this PR added this and also added corresponding support in graph mode Test Plan: python test/test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: `calculate_qparams` of per channel quantization should return the axis, this PR added this and also added corresponding support in graph mode Test Plan: python test/test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: `calculate_qparams` of per channel quantization should return the axis, this PR added this and also added corresponding support in graph mode Test Plan: python test/test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
ZolotukhinM
approved these changes
Nov 16, 2019
Summary: `calculate_qparams` of per channel quantization should return the axis, this PR added this and also added corresponding support in graph mode Test Plan: python test/test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: `calculate_qparams` of per channel quantization should return the axis, this PR added this and also added corresponding support in graph mode Test Plan: python test/test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: `calculate_qparams` of per channel quantization should return the axis, this PR added this and also added corresponding support in graph mode Test Plan: python test/test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: Differential Revision: [D18580905](https://our.internmc.facebook.com/intern/diff/D18580905) [ghstack-poisoned]
Summary: `calculate_qparams` of per channel quantization should return the axis, this PR added this and also added corresponding support in graph mode Test Plan: python test/test_jit.py Reviewers: mvz Subscribers: Tasks: Tags: Differential Revision: [D18580905](https://our.internmc.facebook.com/intern/diff/D18580905) [ghstack-poisoned]
Contributor
|
This pull request has been merged in f2b851a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
torch.jit.ignore#29416 [quant] Make PerChannelMinMaxObserver scriptable usingtorch.jit.ignoreSummary:
calculate_qparamsof per channel quantization should return the axis, thisPR added this and also added corresponding support in graph mode
Test Plan:
python test/test_jit.py
Reviewers:
mvz
Subscribers:
Tasks:
Tags:
Differential Revision: D18580905