[jit] Simplify ScriptModule bindings. #29432
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes a lot of the private methods on torch._C.ScriptModule, and instead implements functionality in terms of slot_dict_impl views to implement _parameter, _buffers, and _modules in nn.Module. A followup PR should also remove the _register_attribute, _register_module, and _register_parameter methods, but this requires more refactoring of the way tracing creates modules and replication for data parallel works.
facebook-github-bot
added
the
oncall: jit
[jit] Simplify ScriptModule bindings. This removes a lot of the private methods on torch._C.ScriptModule, and instead implements functionality in terms of slot_dict_impl views to implement _parameter, _buffers, and _modules in nn.Module. A followup PR should also remove the _register_attribute, _register_module, and _register_parameter methods, but this requires more refactoring of the way tracing creates modules and replication for data parallel works. gh-metadata: pytorch pytorch 29432 gh/zdevito/132/head
Contributor
Contributor
|
I know this is probably the wrong place to ask, but I've gotta know. Since the plan is to also factor out Would this still be possible to achieve through |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This removes a lot of the private methods on torch._C.ScriptModule,
and instead implements functionality in terms of slot_dict_impl views
to implement _parameter, _buffers, and _modules in nn.Module.
A followup PR should also remove the _register_attribute,
_register_module, and _register_parameter methods, but this requires
more refactoring of the way tracing creates modules and replication
for data parallel works.
Differential Revision: D18387963