Use handle pool to manage cusparse handles #29426
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngimel
approved these changes
Nov 8, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
mruberry
changed the title
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Nov 10, 2019
Summary: Fixes pytorch/pytorch#29352 The newly added test fails consistently with illegal memory access without this PR, and now it succeeds consistently. Pull Request resolved: pytorch/pytorch#29426 Differential Revision: D18407784 Pulled By: ngimel fbshipit-source-id: 6cabb9a6674c25f7d7a3dc7b3bac99002018d8ee
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29352
The newly added test fails consistently with illegal memory access without this PR, and now it succeeds consistently.