Skip to content

Update fbjni and enable PyTorch JNI build #29413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dreiss wants to merge 10 commits into from
Closed

Update fbjni and enable PyTorch JNI build #29413

dreiss wants to merge 10 commits into from

Conversation

@dreiss
Copy link
Contributor

@dreiss dreiss commented Nov 7, 2019 •
edited
Loading

Stack from ghstack:

Summary:
Add a "BUILD_JNI" option that enables building PyTorch JNI bindings and
fbjni. This is off by default because it adds a dependency on jni.h.

Also update to the latest fbjni so we can inhibit building its tests,
because they depend on gtest.

Test Plan:

  • Built on dev server.
  • Verified that libpytorch_jni links after libtorch when both are built
    in a parallel build.

@dreiss
Update fbjni and enable PyTorch JNI build
fc51b0b 
Summary:
Add a "BUILD_JNI" option that enables building PyTorch JNI bindings and
fbjni.  This is off by default because it adds a dependency on jni.h.

Also update to the latest fbjni so we can inhibit building its tests,
because they depend on gtest.

Test Plan:
- Built on dev server.
- Verified that libpytorch_jni links after libtorch when both are built
  in a parallel build.
@dreiss dreiss mentioned this pull request Nov 7, 2019
Closed
dreiss added a commit that referenced this pull request Nov 7, 2019
@dreiss
Update fbjni and enable PyTorch JNI build
7fc3993 
Summary:
Add a "BUILD_JNI" option that enables building PyTorch JNI bindings and
fbjni.  This is off by default because it adds a dependency on jni.h.

Also update to the latest fbjni so we can inhibit building its tests,
because they depend on gtest.

Test Plan:
- Built on dev server.
- Verified that libpytorch_jni links after libtorch when both are built
  in a parallel build.

ghstack-source-id: 589a7f3
Pull Request resolved: #29413
@dreiss dreiss mentioned this pull request Nov 7, 2019
Closed
@dreiss dreiss requested review from IvanKobzarev and kostmo November 7, 2019 22:19
@dreiss
Update on "Update fbjni and enable PyTorch JNI build"
2b21ac3 
Summary:
Add a "BUILD_JNI" option that enables building PyTorch JNI bindings and
fbjni.  This is off by default because it adds a dependency on jni.h.

Also update to the latest fbjni so we can inhibit building its tests,
because they depend on gtest.

Test Plan:
- Built on dev server.
- Verified that libpytorch_jni links after libtorch when both are built
  in a parallel build.
@dreiss dreiss mentioned this pull request Nov 8, 2019
Closed
dreiss added a commit that referenced this pull request Nov 8, 2019
@dreiss
Update fbjni and enable PyTorch JNI build
66e3cbf 
Summary:
Add a "BUILD_JNI" option that enables building PyTorch JNI bindings and
fbjni.  This is off by default because it adds a dependency on jni.h.

Also update to the latest fbjni so we can inhibit building its tests,
because they depend on gtest.

Test Plan:
- Built on dev server.
- Verified that libpytorch_jni links after libtorch when both are built
  in a parallel build.

ghstack-source-id: 03da950
Pull Request resolved: #29413
@dreiss
Update on "Update fbjni and enable PyTorch JNI build"
8bf6b61 
Summary:
Add a "BUILD_JNI" option that enables building PyTorch JNI bindings and
fbjni.  This is off by default because it adds a dependency on jni.h.

Also update to the latest fbjni so we can inhibit building its tests,
because they depend on gtest.

Test Plan:
- Built on dev server.
- Verified that libpytorch_jni links after libtorch when both are built
  in a parallel build.
@dreiss
Update on "Update fbjni and enable PyTorch JNI build"
f39f996 
Summary:
Add a "BUILD_JNI" option that enables building PyTorch JNI bindings and
fbjni.  This is off by default because it adds a dependency on jni.h.

Also update to the latest fbjni so we can inhibit building its tests,
because they depend on gtest.

Test Plan:
- Built on dev server.
- Verified that libpytorch_jni links after libtorch when both are built
  in a parallel build.
@dreiss
Update on "Update fbjni and enable PyTorch JNI build"
cc1715c 
Summary:
Add a "BUILD_JNI" option that enables building PyTorch JNI bindings and
fbjni.  This is off by default because it adds a dependency on jni.h.

Also update to the latest fbjni so we can inhibit building its tests,
because they depend on gtest.

Test Plan:
- Built on dev server.
- Verified that libpytorch_jni links after libtorch when both are built
  in a parallel build.
dreiss added a commit that referenced this pull request Nov 13, 2019
@dreiss
Update fbjni and enable PyTorch JNI build
9a06e02 
Summary:
- Add a "BUILD_JNI" option that enables building PyTorch JNI bindings and
  fbjni.  This is off by default because it adds a dependency on jni.h.
- Update to the latest fbjni so we can inhibit building its tests,
  because they depend on gtest.
- Set JAVA_HOME and BUILD_JNI in Linux binary build configurations if we
  can find jni.h in Docker.

Test Plan:
- Built on dev server.
- Verified that libpytorch_jni links after libtorch when both are built
  in a parallel build.

ghstack-source-id: f9908e1
Pull Request resolved: #29413
@dreiss
Update on "Update fbjni and enable PyTorch JNI build"
3388b36 
Summary:
Add a "BUILD_JNI" option that enables building PyTorch JNI bindings and
fbjni.  This is off by default because it adds a dependency on jni.h.

Also update to the latest fbjni so we can inhibit building its tests,
because they depend on gtest.

Test Plan:
- Built on dev server.
- Verified that libpytorch_jni links after libtorch when both are built
  in a parallel build.
dreiss added a commit that referenced this pull request Nov 14, 2019
@dreiss
Update fbjni and enable PyTorch JNI build
8672e4a 
Summary:
- Add a "BUILD_JNI" option that enables building PyTorch JNI bindings and
  fbjni.  This is off by default because it adds a dependency on jni.h.
- Update to the latest fbjni so we can inhibit building its tests,
  because they depend on gtest.
- Set JAVA_HOME and BUILD_JNI in Linux binary build configurations if we
  can find jni.h in Docker.

Test Plan:
- Built on dev server.
- Verified that libpytorch_jni links after libtorch when both are built
  in a parallel build.

ghstack-source-id: 128c672
Pull Request resolved: #29413
@dreiss
Update on "Update fbjni and enable PyTorch JNI build"
b2af735 
Summary:
Add a "BUILD_JNI" option that enables building PyTorch JNI bindings and
fbjni.  This is off by default because it adds a dependency on jni.h.

Also update to the latest fbjni so we can inhibit building its tests,
because they depend on gtest.

Test Plan:
- Built on dev server.
- Verified that libpytorch_jni links after libtorch when both are built
  in a parallel build.
@dreiss dreiss mentioned this pull request Nov 14, 2019
Closed
@dreiss
Update on "Update fbjni and enable PyTorch JNI build"
90d5415 
Summary:
Add a "BUILD_JNI" option that enables building PyTorch JNI bindings and
fbjni.  This is off by default because it adds a dependency on jni.h.

Also update to the latest fbjni so we can inhibit building its tests,
because they depend on gtest.

Test Plan:
- Built on dev server.
- Verified that libpytorch_jni links after libtorch when both are built
  in a parallel build.
@dreiss
Update on "Update fbjni and enable PyTorch JNI build"
3eeb32d 
Summary:
Add a "BUILD_JNI" option that enables building PyTorch JNI bindings and
fbjni.  This is off by default because it adds a dependency on jni.h.

Also update to the latest fbjni so we can inhibit building its tests,
because they depend on gtest.

Test Plan:
- Built on dev server.
- Verified that libpytorch_jni links after libtorch when both are built
  in a parallel build.
dreiss added a commit that referenced this pull request Nov 15, 2019
@dreiss
Update fbjni and enable PyTorch JNI build
c248a66 
Summary:
- Add a "BUILD_JNI" option that enables building PyTorch JNI bindings and
  fbjni.  This is off by default because it adds a dependency on jni.h.
- Update to the latest fbjni so we can inhibit building its tests,
  because they depend on gtest.
- Set JAVA_HOME and BUILD_JNI in Linux binary build configurations if we
  can find jni.h in Docker.

Test Plan:
- Built on dev server.
- Verified that libpytorch_jni links after libtorch when both are built
  in a parallel build.

ghstack-source-id: cafc1e3
Pull Request resolved: #29413
@dreiss
Update on "Update fbjni and enable PyTorch JNI build"
17036fc 
Summary:
Add a "BUILD_JNI" option that enables building PyTorch JNI bindings and
fbjni.  This is off by default because it adds a dependency on jni.h.

Also update to the latest fbjni so we can inhibit building its tests,
because they depend on gtest.

Test Plan:
- Built on dev server.
- Verified that libpytorch_jni links after libtorch when both are built
  in a parallel build.
dreiss added a commit that referenced this pull request Nov 15, 2019
@dreiss
Update fbjni and enable PyTorch JNI build
948d158 
Summary:
- Add a "BUILD_JNI" option that enables building PyTorch JNI bindings and
  fbjni.  This is off by default because it adds a dependency on jni.h.
- Update to the latest fbjni so we can inhibit building its tests,
  because they depend on gtest.
- Set JAVA_HOME and BUILD_JNI in Linux binary build configurations if we
  can find jni.h in Docker.

Test Plan:
- Built on dev server.
- Verified that libpytorch_jni links after libtorch when both are built
  in a parallel build.

ghstack-source-id: d411953
Pull Request resolved: #29413
dreiss added a commit to dreiss/pytorch that referenced this pull request Nov 15, 2019
@dreiss
Update fbjni and enable PyTorch JNI build
826e4be 
Summary:
- Add a "BUILD_JNI" option that enables building PyTorch JNI bindings and
  fbjni.  This is off by default because it adds a dependency on jni.h.
- Update to the latest fbjni so we can inhibit building its tests,
  because they depend on gtest.
- Set JAVA_HOME and BUILD_JNI in Linux binary build configurations if we
  can find jni.h in Docker.

Test Plan:
- Built on dev server.
- Verified that libpytorch_jni links after libtorch when both are built
  in a parallel build.

ghstack-source-id: d411953
Pull Request resolved: pytorch#29413
@dreiss
Copy link
Contributor Author

dreiss commented Dec 5, 2019

This landed.

@dreiss dreiss closed this Dec 5, 2019
@facebook-github-bot facebook-github-bot deleted the gh/dreiss/15/head branch January 4, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IvanKobzarev IvanKobzarev IvanKobzarev approved these changes

@kostmo kostmo Awaiting requested review from kostmo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dreiss @IvanKobzarev