Rename PyTorch JNI library to pytorch_jni #29412
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Originally, this was going to be Android-only, so the name wasn't too important. But now that we're planning to distribute it with libtorch, we should give it a more distinctive name. Test Plan: Ran tests according to #6570 (comment)
IvanKobzarev
approved these changes
Nov 8, 2019
Contributor
|
Two more place to change "pytorch" -> "pytorch_jni" in tests:
|
Summary: Originally, this was going to be Android-only, so the name wasn't too important. But now that we're planning to distribute it with libtorch, we should give it a more distinctive name. Test Plan: Ran tests according to #6570 (comment)
dreiss
added a commit
to dreiss/pytorch
that referenced
this pull request
Nov 8, 2019
Summary: Originally, this was going to be Android-only, so the name wasn't too important. But now that we're planning to distribute it with libtorch, we should give it a more distinctive name. Test Plan: Ran tests according to pytorch#6570 (comment) ghstack-source-id: 856326a Pull Request resolved: pytorch#29412
Contributor
|
This pull request has been merged in c1140f2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Originally, this was going to be Android-only, so the name wasn't too
important. But now that we're planning to distribute it with libtorch,
we should give it a more distinctive name.
Test Plan:
Ran tests according to
#6570 (comment)