[JIT] Make jit.trace_module reentrant #29411
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
facebook-github-bot
added
the
oncall: jit
suo
reviewed
Nov 7, 2019
| check_tolerance, _force_outplace, True, _module_class) | ||
|
|
||
| torch.jit._trace_module_map = None | ||
| old_module_map = torch.jit._trace_module_map |
Member
There was a problem hiding this comment.
can we add a comment here? So next time we don't have to "wtf" our way through the code again.
Collaborator
Author
There was a problem hiding this comment.
I mean it's pretty self explanatory now. The issue was discovering that this was needed in the first place :p
Collaborator
There was a problem hiding this comment.
the usual pattern to do such things is to only replace the attribute when you finish computing it, i.e., start with a local _trace_module_map and only do torch.jit._trace_module_map = _trace_module_map at the end.
Contributor
|
@jamesr66a merged this pull request in 782e80e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Fixes #29367
Differential Revision: D18380559