Make all non-input arguments to functionals part of its options, and pass functional options by const-ref when possible #29404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yf225
requested review from
pbelevich
and removed request for
ebetica and
goldsborough
Member
CircleCI build failures summaryAs of commit 2c9c40c:
Here are the reasons each build failed. This comment was automatically generated by Dr. CI. Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 14 time(s). |
…tions" Make all non-input arguments to functionals part of its options gh-metadata: pytorch pytorch 29404 gh/yf225/41/head
added 3 commits
November 8, 2019 13:02
…tions" Make all non-input arguments to functionals part of its options gh-metadata: pytorch pytorch 29404 gh/yf225/41/head
…tions" Make all non-input arguments to functionals part of its options gh-metadata: pytorch pytorch 29404 gh/yf225/41/head
…tions" Make all non-input arguments to functionals part of its options gh-metadata: pytorch pytorch 29404 gh/yf225/41/head
added 3 commits
November 8, 2019 16:19
…tions" Make all non-input arguments to functionals part of its options gh-metadata: pytorch pytorch 29404 gh/yf225/41/head
…tions" Make all non-input arguments to functionals part of its options gh-metadata: pytorch pytorch 29404 gh/yf225/41/head
…tions" Make all non-input arguments to functionals part of its options gh-metadata: pytorch pytorch 29404 gh/yf225/41/head
This was referenced Nov 11, 2019
…tions" Make all non-input arguments to functionals part of its options gh-metadata: pytorch pytorch 29404 gh/yf225/41/head
pbelevich
reviewed
Nov 11, 2019
…tions" Make all non-input arguments to functionals part of its options gh-metadata: pytorch pytorch 29404 gh/yf225/41/head
yf225
changed the title
pbelevich
approved these changes
Nov 12, 2019
pbelevich
reviewed
Nov 12, 2019
Contributor
pbelevich
left a comment
pbelevich
left a comment
There was a problem hiding this comment.
/// Options for the `BatchNorm` module.
struct TORCH_API BatchNormFuncOptions {
Should be functional instead of module
…tions, and pass functional options by const-ref when possible" Make all non-input arguments to functionals part of its options gh-metadata: pytorch pytorch 29404 gh/yf225/41/head
Contributor
Author
Thanks for the catch! I will fix this in a follow-up doc cleaning PR |
Contributor
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 14, 2019
Summary: Pull Request resolved: #29673 Following #29364 and #29404, this PR makes `F::EmbeddingFuncOptions` and `F::EmbeddingBagFuncOptions` separate classes from `torch::nn::EmbeddingOptions` and `torch::nn::EmbeddingBagOptions`, so that it's easier to enforce that arguments such as `num_embeddings` and `embedding_dim` are required for `torch::nn::EmbeddingOptions` and `torch::nn::EmbeddingBagOptions`. Test Plan: Imported from OSS Differential Revision: D18462540 Pulled By: yf225 fbshipit-source-id: f2abf431e48675b0a9d7f6f398cdb90ff9037c35
csarofeen
pushed a commit
to mruberry/pytorch
that referenced
this pull request
Nov 18, 2019
…9673) Summary: Pull Request resolved: pytorch#29673 Following pytorch#29364 and pytorch#29404, this PR makes `F::EmbeddingFuncOptions` and `F::EmbeddingBagFuncOptions` separate classes from `torch::nn::EmbeddingOptions` and `torch::nn::EmbeddingBagOptions`, so that it's easier to enforce that arguments such as `num_embeddings` and `embedding_dim` are required for `torch::nn::EmbeddingOptions` and `torch::nn::EmbeddingBagOptions`. Test Plan: Imported from OSS Differential Revision: D18462540 Pulled By: yf225 fbshipit-source-id: f2abf431e48675b0a9d7f6f398cdb90ff9037c35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This PR makes all non-input arguments to functionals part of its options parameters, so that we won't break backward compatibility even if we add or reorder some of the non-input arguments to functionals in the future.
Differential Revision: D18378526