[C++ API] Add functional overloads for pixelshuffle, pooling, upsampling, vision #29359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 7, 2019
added 2 commits
November 7, 2019 00:25
…ling, vision" Add functional overloads for pixelshuffle, pooling, upsampling, vision gh-metadata: pytorch pytorch 29359 gh/yf225/38/head
…ling, vision" Add functional overloads for pixelshuffle, pooling, upsampling, vision gh-metadata: pytorch pytorch 29359 gh/yf225/38/head
yf225
changed the title
yf225
requested review from
pbelevich
and removed request for
ebetica and
goldsborough
Member
CircleCI build failures summaryAs of commit e12d49a:
Here are the reasons each build failed. This comment was automatically generated by Dr. CI. Please report bugs/suggestions on the GitHub issue tracker. |
pbelevich
reviewed
Nov 8, 2019
Contributor
|
If |
…ng, upsampling, vision" Add functional overloads for pixelshuffle, pooling, upsampling, vision gh-metadata: pytorch pytorch 29359 gh/yf225/38/head
added 3 commits
November 8, 2019 13:02
…ng, upsampling, vision" Add functional overloads for pixelshuffle, pooling, upsampling, vision gh-metadata: pytorch pytorch 29359 gh/yf225/38/head
…ng, upsampling, vision" Add functional overloads for pixelshuffle, pooling, upsampling, vision gh-metadata: pytorch pytorch 29359 gh/yf225/38/head
…ng, upsampling, vision" Add functional overloads for pixelshuffle, pooling, upsampling, vision gh-metadata: pytorch pytorch 29359 gh/yf225/38/head
Contributor
Author
Thanks a lot for the suggestion - I removed the default values from all of them. |
pbelevich
approved these changes
Nov 8, 2019
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This PR adds functional overloads that take the full set of arguments (instead of just Options) for the following functionals:
These new functionals lives in the
torch::nn::functional::detailnamespace and they are only meant to be called from the module forward methods (i.e. they are not public API). This is in preparation for the future change where we make module Options and functional Options two different classes, because if the module forward method has to construct a new functional Options object every time it runs it will be pretty silly and bad performance.Differential Revision: D18376978