Skip to content

Conversation

@neginraoof
Copy link
Contributor

@neginraoof neginraoof commented Nov 7, 2019

Fixed random generator symbolics, and added rand_like.

neginraoof and others added 19 commits October 22, 2019 09:39
@neginraoof
Copy link
Contributor Author

neginraoof commented Nov 7, 2019

@houseroad I fixed the failure in tests and resubmitted this. There was a PR to fix outplace jit tracing for *_like operators (#28839) that modified the arguments for *_like ops. I updated the PR.

@neginraoof
Copy link
Contributor Author

Failure is:
Can NOT find backward compatible schemas after changes for schema aten::_batch_norm_impl_index
This does not look related

@neginraoof
Copy link
Contributor Author

@houseroad This PR is the re-submission of #28470
Tests look fine. Please review. Thanks

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@facebook-github-bot
Copy link
Contributor

@houseroad merged this pull request in 64a66e8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants