[quantization] Fix tracing for dynamic quantized LSTM #29331
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Closes #27954
This fixes the hard-coding of packed parameter values for the dynamic quantized LSTM by orchestrating the following dance:
__getstate__and setstate` method s.t. packed weights are properly re-done on model load.torch.nn.ModuleList, s.t. the parameters appear as attributes in the hierarchy. Then,gatherParametersAndBuffers(pytorch/torch/csrc/jit/tracer.cpp
Line 285 in 9c43b16
Value*for them in the traced graph.ListConstructwith each of the proper parameter values. In scripting, theModuleListis const, so it can be unrolled into the graph and a subsequentListConstructdoes its business.The
forwardof the traced LSTM before and after this change are as follows:Before
After
Differential Revision: D18374904