Revert cudnn changes #23861 #29329
Closed
Revert cudnn changes #23861 #29329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```python
x = torch.randn(192,16,50).cuda()
x = x.permute(0,2,1).contiguous().permute(0,2,1)
m = torch.nn.Conv1d(
in_channels=16,
out_channels=32,
kernel_size=2,
bias=True,
).cuda()
m(x)
```
This reverts commit 8160f39.
VitalyFedyunin
changed the title
facebook-github-bot
added
the
oncall: jit
ifedan
approved these changes
Nov 6, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@VitalyFedyunin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ezyang
approved these changes
Nov 6, 2019
Collaborator
|
Fill in the information here: The implementation here forgot to accommodate the case where 1d convolution got converted to 2d convolution: https://github.com/pytorch/pytorch/blob/master/aten/src/ATen/native/Convolution.cpp#L567-L571 So 1d conv is accidentally routed through NHWC (not desired behavior), which I'll fix and submit another PR. Meanwhile, cuDNN is actually supposed to handle this normally instead of error out. I'm working with the team to fix it. |
Contributor
|
@VitalyFedyunin merged this pull request in 9a9bb44. |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Nov 7, 2019
Summary:
Broken case:
```python
x = torch.randn(192,16,50).cuda()
x = x.permute(0,2,1).contiguous().permute(0,2,1)
m = torch.nn.Conv1d(
in_channels=16,
out_channels=32,
kernel_size=2,
bias=True,
).cuda()
m(x)
```
This reverts commit 8160f390cf678b3b98e0c1f73bd289ee3c96afcb.
Pull Request resolved: pytorch/pytorch#29329
Differential Revision: D18357674
Pulled By: VitalyFedyunin
fbshipit-source-id: cdd7e77e8dcbfc5f2ab3df54eb53ccfbf703b245
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken case:
This reverts commit 8160f39.