Make PyTorch Python 3.8 compatible #29302
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PEP 590 modifies the `tp_print` offset to `tp_vectorcall_offset` - which requires a Py_ssize_t object. Passing a nullptr caused compatibility issues for Python 3.8. Changelog: - Modify all occurrences of `nullptr /* tp_print */` to 0 /* tp_vectorcall_offset */ Test Plan: - Local fresh build with Python 3.8 completed successfully.
soumith
approved these changes
Nov 7, 2019
Contributor
|
cc: @suo we need to make clang-tidy shut-up because it's wrong in this case. how do we do so? |
Contributor
Author
|
I believe the errors can be silenced by: |
ezyang
approved these changes
Nov 7, 2019
Contributor
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
I'm not going to block this diff on suppressions
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP 590 modifies the
tp_printoffset totp_vectorcall_offset- which requires a Py_ssize_t object.Passing a nullptr caused compatibility issues for Python 3.8.
Changelog:
nullptr /* tp_print */to 0 /* tp_vectorcall_offset */Test Plan:
Fixes #28060.
Fixes #29162.
Supersedes #28364