-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Enable multinomial for torch.half #29266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changelog: - Re-enable multinomial sampling when the probability tensor has `dtype == torch.half`.
|
test? |
|
@ezyang Tests have been added. |
|
build failure is real |
|
@ezyang, this seems to me like a clang specific error. Do you have recommendations for a fix? |
|
Well, I'm not too sure about this case specifically, but usually if a |
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Changelog:
dtype == torch.half.It seems to have been missed in #28481.
Fixes #29211