[android][gradle] Gradle build with offline dependencies #29262
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanKobzarev
changed the title
IvanKobzarev
force-pushed
the
ik_android_circleci_gradle_offline_build
branch
25 times, most recently
from
6cc4cd5 to
4cdd0e1
Compare
IvanKobzarev
force-pushed
the
ik_android_circleci_gradle_offline_build
branch
from
4cdd0e1 to
29fa4a1
Compare
IvanKobzarev
force-pushed
the
ik_android_circleci_gradle_offline_build
branch
from
29fa4a1 to
0ff632d
Compare
ezyang
approved these changes
Nov 12, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@IvanKobzarev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
IvanKobzarev
force-pushed
the
ik_android_circleci_gradle_offline_build
branch
4 times, most recently
from
49f2d11 to
7e5429c
Compare
dreiss
approved these changes
Nov 13, 2019
IvanKobzarev
force-pushed
the
ik_android_circleci_gradle_offline_build
branch
3 times, most recently
from
fc96125 to
758f530
Compare
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@IvanKobzarev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
IvanKobzarev
force-pushed
the
ik_android_circleci_gradle_offline_build
branch
from
758f530 to
53e23ae
Compare
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@IvanKobzarev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@IvanKobzarev merged this pull request in d8732b3. |
Contributor
|
It doesn't look like this is working. Make sure you test by explicitly enabling the gradle job in your PR before landing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#29159
Introducing GRADLE_OFFLINE environment variable to use '--offline' gradle argument which will only use local gradle cache without network.
As it is cache and has some expiration logic - before every start of gradle 'touch' files to update last access time.
Deploying new docker images that includes prefetching to gradle cache all android dependencies, commit with update of docker images: pytorch/pytorch-ci-dockerfiles@df07dd5
Reenable android gradle jobs on CI (revert of 54e6a7e)