Skip to content

Conversation

@jamesr66a
Copy link
Collaborator

@jamesr66a jamesr66a commented Nov 6, 2019

Stack from ghstack:

Differential Revision: D18343363

[ghstack-poisoned]
@jamesr66a jamesr66a requested a review from apaszke as a code owner November 6, 2019 01:25
jamesr66a pushed a commit that referenced this pull request Nov 6, 2019
ghstack-source-id: 5f6beb0
Pull Request resolved: #29261
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Nov 6, 2019
@jamesr66a jamesr66a requested a review from zdevito November 6, 2019 01:26
@jamesr66a jamesr66a requested a review from suo November 6, 2019 03:29
jamesr66a pushed a commit that referenced this pull request Nov 6, 2019
ghstack-source-id: d6ddfec
Pull Request resolved: #29261
@jamesr66a jamesr66a changed the title [WIP][JIT] Trace module calls [JIT] Trace module calls Nov 6, 2019
Copy link
Contributor

@zdevito zdevito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Only minor asks for comments.

jamesr66a pushed a commit that referenced this pull request Nov 6, 2019
ghstack-source-id: ea63b84
Pull Request resolved: #29261
@facebook-github-bot
Copy link
Contributor

@jamesr66a merged this pull request in 309b28e.

zdevito pushed a commit to zdevito/ATen that referenced this pull request Nov 7, 2019
Summary: Pull Request resolved: pytorch/pytorch#29261

Test Plan: Imported from OSS

Differential Revision: D18343363

Pulled By: jamesr66a

fbshipit-source-id: 0c6394205e2c0ea8708028d20df83fe17b466ff4
@facebook-github-bot facebook-github-bot deleted the gh/jamesr66a/138/head branch November 10, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants