-
Notifications
You must be signed in to change notification settings - Fork 26.3k
[JIT] Trace module calls #29261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
[JIT] Trace module calls #29261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
[ghstack-poisoned]
Differential Revision: [D18343363](https://our.internmc.facebook.com/intern/diff/D18343363) [ghstack-poisoned]
zdevito
approved these changes
Nov 6, 2019
Contributor
zdevito
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Only minor asks for comments.
Differential Revision: [D18343363](https://our.internmc.facebook.com/intern/diff/D18343363) [ghstack-poisoned]
Contributor
|
@jamesr66a merged this pull request in 309b28e. |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Nov 7, 2019
Summary: Pull Request resolved: pytorch/pytorch#29261 Test Plan: Imported from OSS Differential Revision: D18343363 Pulled By: jamesr66a fbshipit-source-id: 0c6394205e2c0ea8708028d20df83fe17b466ff4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D18343363