Skip to content

Conversation

@xta0
Copy link
Contributor

@xta0 xta0 commented Nov 5, 2019

Stack from ghstack:

Summary

If you run the TestApp using Cocoapods, you'll likely run into an error due to the lack of config.json in the main bundle. This PR fixes this crash and updates the README as well.

Test Plan

  • Don't break CIs

Differential Revision: D18339047

xta0 added a commit that referenced this pull request Nov 5, 2019
ghstack-source-id: b2cf265
Pull Request resolved: #29247
@xta0 xta0 requested review from ljk53 and shoumikhin and removed request for shoumikhin November 5, 2019 23:23
@xta0 xta0 added the module: ios Related to iOS support - build, API, Continuous Integration, document label Nov 5, 2019
@xta0 xta0 requested a review from dreiss November 5, 2019 23:26
@xta0 xta0 changed the title [iOS] Fix TestApp [iOS] Fix the TestApp Nov 5, 2019
@facebook-github-bot
Copy link
Contributor

@xta0 merged this pull request in 30f88bb.

@facebook-github-bot facebook-github-bot deleted the gh/xta0/41/head branch November 9, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged module: ios Related to iOS support - build, API, Continuous Integration, document

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants