Fix when giving jit format warning about unsupported options, second attempt #29193
Conversation
…attempt Previous attempt in #28616 didn't work in clang8 and got reverted in #28916 This one escapes the } inside the brackets, maybe that works Differential Revision: [D18324286](https://our.internmc.facebook.com/intern/diff/D18324286/) [ghstack-poisoned]
facebook-github-bot
added
the
oncall: jit
…attempt Previous attempt in #28616 didn't work in clang8 and got reverted in #28916 This one escapes the } inside the brackets, maybe that works Differential Revision: [D18324286](https://our.internmc.facebook.com/intern/diff/D18324286/) ghstack-source-id: 93270628 Pull Request resolved: #29193
…ns, second attempt" Previous attempt in #28616 didn't work in clang8 and got reverted in #28916 This one escapes the } inside the brackets, maybe that works Differential Revision: [D18324286](https://our.internmc.facebook.com/intern/diff/D18324286/) [ghstack-poisoned]
…attempt Pull Request resolved: #29193 Previous attempt in #28616 didn't work in clang8 and got reverted in #28916 This one escapes the } inside the brackets, maybe that works ghstack-source-id: 93283014 Differential Revision: [D18324286](https://our.internmc.facebook.com/intern/diff/D18324286/)
|
cc @jamesr66a |
jamesr66a
left a comment
jamesr66a
left a comment
There was a problem hiding this comment.
I tried a bunch of escaping, including this one and it didn’t work. The issue is it’s throwing an error about square brackets, not braces, but the square brackets are well formed anyway so the standard library just seems broken.
Like I said ok the other PR, we should be able to get the desired behavior by just using a one or more match (+) with a non-greedy search(?). I don’t think we need to explicitly exclude closed braces
|
@jamesr66a That won't work with multiple format arguments as it will match the opening { of the first {} with the closing } of the second {} |
|
@ggoossen that's not the case if you use a non-greedy match (the question mark token) |
Stack from ghstack:
Previous attempt in #28616 didn't work in clang8 and got reverted in #28916
This one escapes the } inside the brackets, maybe that works
Differential Revision: D18324286