Skip to content

Conversation

@pritamdamania87
Copy link
Contributor

@pritamdamania87 pritamdamania87 commented Nov 5, 2019

Stack from ghstack:

Updates our docs to include a design doc for distributed autograd.
Currently, this doc only covers the FAST mode algorithm. The Smart mode
algorithm section just refers to the original RFC.

There is a section for Distributed Optimizer that we can complete once we've
finalized the API for the same.

Differential Revision: D18318949

Updates our docs to include a design doc for distributed autograd.
Currently, this doc only covers the FAST mode algorithm. The Smart mode
algorithm section just refers to the original RFC.

There is a section for Distributed Optimizer that we can complete once we've
finalized the API for the same.

Differential Revision: [D18318949](https://our.internmc.facebook.com/intern/diff/D18318949/)

[ghstack-poisoned]
pritamdamania87 pushed a commit that referenced this pull request Nov 5, 2019
Updates our docs to include a design doc for distributed autograd.
Currently, this doc only covers the FAST mode algorithm. The Smart mode
algorithm section just refers to the original RFC.

There is a section for Distributed Optimizer that we can complete once we've
finalized the API for the same.

Differential Revision: [D18318949](https://our.internmc.facebook.com/intern/diff/D18318949/)

ghstack-source-id: 93254358
Pull Request resolved: #29175
Updates our docs to include a design doc for distributed autograd.
Currently, this doc only covers the FAST mode algorithm. The Smart mode
algorithm section just refers to the original RFC.

There is a section for Distributed Optimizer that we can complete once we've
finalized the API for the same.

Differential Revision: [D18318949](https://our.internmc.facebook.com/intern/diff/D18318949/)

[ghstack-poisoned]
pritamdamania87 pushed a commit that referenced this pull request Nov 8, 2019
Pull Request resolved: #29175

Updates our docs to include a design doc for distributed autograd.
Currently, this doc only covers the FAST mode algorithm. The Smart mode
algorithm section just refers to the original RFC.

There is a section for Distributed Optimizer that we can complete once we've
finalized the API for the same.
ghstack-source-id: 93560691

Differential Revision: [D18318949](https://our.internmc.facebook.com/intern/diff/D18318949/)
@pritamdamania87
Copy link
Contributor Author

@mrshenli @jlin27 Could you take another look at this? I do plan to clean up some parts of this doc as other API docs land.

Copy link
Contributor

@mrshenli mrshenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contents LGTM! Thanks! Please get a stamp from @jlin27 as well.

Updates our docs to include a design doc for distributed autograd.
Currently, this doc only covers the FAST mode algorithm. The Smart mode
algorithm section just refers to the original RFC.

There is a section for Distributed Optimizer that we can complete once we've
finalized the API for the same.

Differential Revision: [D18318949](https://our.internmc.facebook.com/intern/diff/D18318949/)

[ghstack-poisoned]
pritamdamania87 pushed a commit that referenced this pull request Nov 12, 2019
Pull Request resolved: #29175

Updates our docs to include a design doc for distributed autograd.
Currently, this doc only covers the FAST mode algorithm. The Smart mode
algorithm section just refers to the original RFC.

There is a section for Distributed Optimizer that we can complete once we've
finalized the API for the same.
ghstack-source-id: 93701129

Differential Revision: [D18318949](https://our.internmc.facebook.com/intern/diff/D18318949/)
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in c3b2c2e.

@facebook-github-bot facebook-github-bot deleted the gh/pritamdamania87/23/head branch November 16, 2019 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants