Properly shutdown RPC even in the case of clean_shutdown=False.
#29148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We would skip rpc.join_rpc() in the case of `clean_shutdown=False`. This would exit the process without properly cleaning up the local RPCAgent resulting in a crash. As a result, to fix this we still call rpc.join_rpc() even in an unclean shutdown. Note that, rpc.join_rpc() needs to be replaced with a local `shutdown` call eventually since we need a way to shutdown the local RPC agent properly. Differential Revision: [D18306941](https://our.internmc.facebook.com/intern/diff/D18306941/) [ghstack-poisoned]
pritamdamania87
pushed a commit
that referenced
this pull request
Nov 4, 2019
We would skip rpc.join_rpc() in the case of `clean_shutdown=False`. This would exit the process without properly cleaning up the local RPCAgent resulting in a crash. As a result, to fix this we still call rpc.join_rpc() even in an unclean shutdown. Note that, rpc.join_rpc() needs to be replaced with a local `shutdown` call eventually since we need a way to shutdown the local RPC agent properly. Differential Revision: [D18306941](https://our.internmc.facebook.com/intern/diff/D18306941/) ghstack-source-id: 93216133 Pull Request resolved: #29148
Contributor
This should be unblocked once pytorch/gloo#228 is landed. |
…False`." We would skip rpc.join_rpc() in the case of `clean_shutdown=False`. This would exit the process without properly cleaning up the local RPCAgent resulting in a crash. As a result, to fix this we still call rpc.join_rpc() even in an unclean shutdown. Note that, rpc.join_rpc() needs to be replaced with a local `shutdown` call eventually since we need a way to shutdown the local RPC agent properly. Differential Revision: [D18306941](https://our.internmc.facebook.com/intern/diff/D18306941/) [ghstack-poisoned]
pritamdamania87
pushed a commit
that referenced
this pull request
Nov 8, 2019
Pull Request resolved: #29148 We would skip rpc.join_rpc() in the case of `clean_shutdown=False`. This would exit the process without properly cleaning up the local RPCAgent resulting in a crash. As a result, to fix this we still call rpc.join_rpc() even in an unclean shutdown. Note that, rpc.join_rpc() needs to be replaced with a local `shutdown` call eventually since we need a way to shutdown the local RPC agent properly. Differential Revision: [D18306941](https://our.internmc.facebook.com/intern/diff/D18306941/) ghstack-source-id: 93561508
jjlilley
approved these changes
Nov 8, 2019
xush6528
approved these changes
Nov 8, 2019
| # since we need to shutdown the RPC agent. If we don't shutdown the | ||
| # RPC agent, tests would fail since RPC agent threads, locks and | ||
| # condition variables are not properly terminated. | ||
| rpc.join_rpc() |
Contributor
There was a problem hiding this comment.
Yes, replace this with the local shutdown call after the shutdown API is ready.
| fut = rpc.rpc_async(dst_name, set_termination_signal, args=()) | ||
| futs.append(fut) | ||
| for fut in futs: | ||
| assert fut.wait() is None, "Sending termination signal failed." |
Contributor
There was a problem hiding this comment.
And replace this part with the rpc.all_shutdown() API to be added.
Contributor
|
This pull request has been merged in 310343e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
clean_shutdown=False. #29148 Properly shutdown RPC even in the case ofclean_shutdown=False.We would skip rpc.join_rpc() in the case of
clean_shutdown=False.This would exit the process without properly cleaning up the local RPCAgent
resulting in a crash.
As a result, to fix this we still call rpc.join_rpc() even in an unclean
shutdown. Note that, rpc.join_rpc() needs to be replaced with a local
shutdowncall eventually since we need a way to shutdown the local RPC agentproperly.
Differential Revision: D18306941