Skip to content

Conversation

@albanD
Copy link
Collaborator

@albanD albanD commented Nov 4, 2019

Address last comment in #28546

@albanD albanD requested a review from gchanan December 6, 2019 20:24
@albanD
Copy link
Collaborator Author

albanD commented Dec 6, 2019

@pytorchbot rebase this please.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: use the full link. It's not obvious that this is an issue or a PR, and it's not obvious we'll use github forever.

@albanD albanD force-pushed the doc_parallel_for_extra branch from 656d5e7 to 942b498 Compare December 10, 2019 17:11
@kostmo
Copy link
Member

kostmo commented Dec 10, 2019

CircleCI build failures summary

As of commit 942b498:

  • 4/4 broken upstream at merge base 06c7420 (see grid view)
    • You may want to rebase on the viable/strict branch (see its recency history):
      • If your commit is older than viable/strict:
        git fetch viable/strict
        git rebase viable/strict
        
      • If your commit is newer than viable/strict, you can try basing on an older, stable commit:
        git fetch viable/strict
        git rebase --onto viable/strict $(git merge-base origin/master HEAD)
        
  • 0/4 failures introduced in this PR

Detailed failure analysis (WIP)

Here are the reasons each build failed:

4 failures recognized by patterns:

See CircleCI build pytorch_linux_xenial_py2_7_9_build (1/4)

Step: Build (details)

Dec 10 17:20:20 /var/lib/jenkins/workspace/third_party/fbgemm/include/fbgemm/FbgemmFP16.h:243:3: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_build (2/4)

Step: Build (details)

Dec 10 17:20:22 /var/lib/jenkins/workspace/third_party/fbgemm/include/fbgemm/FbgemmFP16.h:243:25: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]

See CircleCI build pytorch_linux_xenial_cuda9_cudnn7_py3_build (3/4)

Step: Build (details)

Dec 10 17:23:40 /var/lib/jenkins/workspace/third_party/fbgemm/include/fbgemm/FbgemmFP16.h:243:25: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]

See CircleCI build pytorch_libtorch_linux_xenial_cuda9_cudnn7_py3_build (4/4)

Step: Build (details)

Dec 10 17:24:14 /var/lib/jenkins/workspace/third_party/fbgemm/include/fbgemm/FbgemmFP16.h:243:25: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]

This comment was automatically generated by Dr. CI.
Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 2 times.

@albanD albanD force-pushed the doc_parallel_for_extra branch from 942b498 to 4d01ba9 Compare December 10, 2019 20:17
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@albanD merged this pull request in 5b03ff0.

wuhuikx pushed a commit to wuhuikx/pytorch that referenced this pull request Jan 30, 2020
Summary:
Address last comment in pytorch#28546
Pull Request resolved: pytorch#29140

Differential Revision: D18915091

Pulled By: albanD

fbshipit-source-id: 756ff5bb6a92d47c80aa9f96ff6f0edea5fd24de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants