-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Update embedding renorm comment to reference fixed issue #29140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@pytorchbot rebase this please. |
aten/src/ATen/native/Embedding.cpp
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: use the full link. It's not obvious that this is an issue or a PR, and it's not obvious we'll use github forever.
656d5e7 to
942b498
Compare
CircleCI build failures summaryAs of commit 942b498:
Detailed failure analysis (WIP)Here are the reasons each build failed: 4 failures recognized by patterns:
|
942b498 to
4d01ba9
Compare
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Address last comment in pytorch#28546 Pull Request resolved: pytorch#29140 Differential Revision: D18915091 Pulled By: albanD fbshipit-source-id: 756ff5bb6a92d47c80aa9f96ff6f0edea5fd24de
Address last comment in #28546