[namedtensor] Add TensorNames::checkUnique, operator<< (TensorName) #29124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TensorNames::checkUnique gives a nice error message if there are duplicate names. Adding operator<< on TensorName cleans up some code. A TensorName gets printed out as: "'H' (index 2 of ['N', 'C', 'H', 'W'])" for example. Test Plan: - New c++ tests. test with `build/bin/NamedTensor_test`. [ghstack-poisoned]
…nsorName)" TensorNames::checkUnique gives a nice error message if there are duplicate names. Adding operator<< on TensorName cleans up some code. A TensorName gets printed out as: "'H' (index 2 of ['N', 'C', 'H', 'W'])" for example. Test Plan: - New c++ tests. test with `build/bin/NamedTensor_test`. [ghstack-poisoned]
…nsorName)" TensorNames::checkUnique gives a nice error message if there are duplicate names. Adding operator<< on TensorName cleans up some code. A TensorName gets printed out as: "'H' (index 2 of ['N', 'C', 'H', 'W'])" for example. Test Plan: - New c++ tests. test with `build/bin/NamedTensor_test`. [ghstack-poisoned]
…nsorName)" TensorNames::checkUnique gives a nice error message if there are duplicate names. Adding operator<< on TensorName cleans up some code. A TensorName gets printed out as: "'H' (index 2 of ['N', 'C', 'H', 'W'])" for example. Test Plan: - New c++ tests. test with `build/bin/NamedTensor_test`. [ghstack-poisoned]
nairbv
approved these changes
Nov 4, 2019
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Nov 5, 2019
Summary: Pull Request resolved: pytorch/pytorch#29124 TensorNames::checkUnique gives a nice error message if there are duplicate names. Adding operator<< on TensorName cleans up some code. A TensorName gets printed out as: "'H' (index 2 of ['N', 'C', 'H', 'W'])" for example. Test Plan: - New c++ tests. test with `build/bin/NamedTensor_test`. Differential Revision: D18311868 Pulled By: zou3519 fbshipit-source-id: 5be197dba227f0328b40d7f66e78fffefe4dbd00
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
TensorNames::checkUnique gives a nice error message if there are
duplicate names.
Adding operator<< on TensorName cleans up some code. A TensorName gets
printed out as: "'H' (index 2 of ['N', 'C', 'H', 'W'])" for example.
Test Plan:
build/bin/NamedTensor_test.Differential Revision: D18311868