Mark c10d::~NCCLUtils as noexcept
#29118
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's never a good idea to throw from a destructor and per #28288 we can't use `std::make_shared` on a class with a `noexcept(false)` destructor. To fix this, we `abort` instead of throw from the `NCCLComm` destructor. Closes #28288. Differential Revision: [D18298271](https://our.internmc.facebook.com/intern/diff/D18298271/) [ghstack-poisoned]
pietern
added a commit
that referenced
this pull request
Nov 4, 2019
It's never a good idea to throw from a destructor and per #28288 we can't use `std::make_shared` on a class with a `noexcept(false)` destructor. To fix this, we `abort` instead of throw from the `NCCLComm` destructor. Closes #28288. Differential Revision: [D18298271](https://our.internmc.facebook.com/intern/diff/D18298271/) ghstack-source-id: 93182910 Pull Request resolved: #29118
pietern
added
the
oncall: distributed
Contributor
Author
|
@pytorchbot retest this please |
mrshenli
reviewed
Nov 5, 2019
| if (result != ncclSuccess) { \ | ||
| std::string err = "NCCL error in: " + std::string(__FILE__) + ":" + \ | ||
| std::to_string(__LINE__) + ", " + ncclGetErrorWithVersion(result); \ | ||
| throw std::runtime_error(err); \ |
Contributor
There was a problem hiding this comment.
This is still used in ~AutoNcclGroup
Contributor
Author
There was a problem hiding this comment.
That's fine; this change only fixes the std::make_shared compile error reported in #28288.
It would be nice to make all destructors noexcept, but that defies the purpose of a RAII wrapper like AutoNcclGroup. If you can't throw from its destructor, you would need to manually check the result of ncclGroupEnd, and the wrapper is no longer useful.
Contributor
Author
|
Test failures are unrelated. |
pritamdamania87
approved these changes
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
c10d::~NCCLUtilsas noexcept #29118 Markc10d::~NCCLUtilsas noexceptIt's never a good idea to throw from a destructor and per #28288 we
can't use
std::make_sharedon a class with anoexcept(false)destructor.
To fix this, we
abortinstead of throw from theNCCLCommdestructor.Closes #28288.
Differential Revision: D18298271