Skip to content

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Nov 1, 2019

Stack from ghstack:

When a tuple is returned, it is helpful to know specifically
which output was the culprit.

Actually, it was somewhat /more/ helpful to actually see the
contents of the tensor which didn't have dependence (or, e.g.,
the backtrace of the code that populated it), but that seemed
a step too far.

Differential Revision: D18274323

When a tuple is returned, it is helpful to know specifically
which output was the culprit.

Actually, it was somewhat /more/ helpful to actually see the
contents of the tensor which didn't have dependence (or, e.g.,
the backtrace of the code that populated it), but that seemed
a step too far.

Differential Revision: [D18274323](https://our.internmc.facebook.com/intern/diff/D18274323/)

[ghstack-poisoned]
@ezyang ezyang requested a review from apaszke as a code owner November 1, 2019 18:00
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Nov 1, 2019
When a tuple is returned, it is helpful to know specifically
which output was the culprit.

Actually, it was somewhat /more/ helpful to actually see the
contents of the tensor which didn't have dependence (or, e.g.,
the backtrace of the code that populated it), but that seemed
a step too far.

Differential Revision: [D18274323](https://our.internmc.facebook.com/intern/diff/D18274323/)

[ghstack-poisoned]
@ezyang ezyang requested review from dreiss and suo November 4, 2019 14:42
Copy link
Member

@suo suo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 215ac10.

@kostmo
Copy link
Member

kostmo commented Nov 6, 2019

CircleCI build failures summary

As of commit a33ca06:

  • 1/1 recognized as flaky
  • 1/1 failures introduced in this PR

Here are the reasons each build failed.


This comment was automatically generated by Dr. CI.
Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

@facebook-github-bot facebook-github-bot deleted the gh/ezyang/514/head branch November 8, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants