Additional autograd unit tests for Python UDFs. #29041
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Enhanced autograd unit tests to test the torch.distributed.autograd.backward() API more thoroughly on Python UDFs. 2) Enhanced `python_error` to override `what` such that it returns an appropriate error string if we call `what()` on this error. This ensures we can propagate exceptions over the wire during RPCs (since we get the error string by calling what() on the exception) ghstack-source-id: 92972494 Differential Revision: [D18273041](https://our.internmc.facebook.com/intern/diff/D18273041/) [ghstack-poisoned]
pritamdamania87
pushed a commit
that referenced
this pull request
Nov 1, 2019
1) Enhanced autograd unit tests to test the torch.distributed.autograd.backward() API more thoroughly on Python UDFs. 2) Enhanced `python_error` to override `what` such that it returns an appropriate error string if we call `what()` on this error. This ensures we can propagate exceptions over the wire during RPCs (since we get the error string by calling what() on the exception) ghstack-source-id: 92972494 Differential Revision: [D18273041](https://our.internmc.facebook.com/intern/diff/D18273041/) ghstack-source-id: 93087189 Pull Request resolved: #29041
Contributor
Author
|
@ezyang I'm not able to reproduce the doxygen issue locally. This is what I did and check-doxygen.sh output: |
Contributor
|
This error may be sensitive to doxygen or dot version, and you may not have lined things up exactly the same way. I was reading through the CI script and it looks like we filter out similar looking warnings. So it might be acceptable to just filter this one out too. |
Contributor
1) Enhanced autograd unit tests to test the torch.distributed.autograd.backward() API more thoroughly on Python UDFs. 2) Enhanced `python_error` to override `what` such that it returns an appropriate error string if we call `what()` on this error. This ensures we can propagate exceptions over the wire during RPCs (since we get the error string by calling what() on the exception) Differential Revision: [D18273041](https://our.internmc.facebook.com/intern/diff/D18273041/) [ghstack-poisoned]
pritamdamania87
requested review from
ebetica,
goldsborough and
yf225
as code owners
pritamdamania87
pushed a commit
that referenced
this pull request
Nov 1, 2019
Pull Request resolved: #29041 1) Enhanced autograd unit tests to test the torch.distributed.autograd.backward() API more thoroughly on Python UDFs. 2) Enhanced `python_error` to override `what` such that it returns an appropriate error string if we call `what()` on this error. This ensures we can propagate exceptions over the wire during RPCs (since we get the error string by calling what() on the exception) ghstack-source-id: 93098679 ghstack-source-id: 93098679 Differential Revision: [D18273041](https://our.internmc.facebook.com/intern/diff/D18273041/)
Contributor
Author
Followed what Alban did there and quick_checks are now passing. Could you approve this PR? Thanks! |
Contributor
|
This pull request has been merged in e8e7d93. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
torch.distributed.autograd.backward() API more thoroughly on Python UDFs.
python_errorto overridewhatsuch that it returns anappropriate error string if we call
what()on this error. This ensures we canpropagate exceptions over the wire during RPCs (since we get the error string
by calling what() on the exception)
Differential Revision: D18273041