Enable ONNX constant folding for opset 11. #29011
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
oncall: jit
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Author
|
Thanks @houseroad . |
Member
Member
|
And other linters |
spandantiwari
force-pushed
the
spandantiwari/enable_constant_fold_opset11
branch
from
d4b6108 to
3b7053a
Compare
Author
@houseroad - updated based on your feedback. Fixed the C++ linter issues. |
Member
|
rebase again? |
Author
I just rebased before submitting. I am not seeing this build failure locally. Will try again. |
spandantiwari
force-pushed
the
spandantiwari/enable_constant_fold_opset11
branch
from
3b7053a to
a305f17
Compare
Author
|
Rebased and started CI again. |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@houseroad merged this pull request in bc91e19. |
Author
|
Thanks @houseroad . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently ONNX constant folding (
do_constant_folding=Truearg intorch.onnx.exportAPI) supports only opset 9 and 10 of ONNX. Opset 11 support was recently introduced in the ONNX exporter. For opset 11, it is currently a no-op. This change enables ONNX constant folding for opset 11. Specifically there are three main changes:test/onnx/test_utility_funs.pyandtest/onnx/test_pytorch_onnx_onnxruntime.pyfor opset 11.