C++ API parity: MarginRankingLoss #29000
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
pbelevich
requested review from
ebetica,
goldsborough and
yf225
as code owners
This was referenced Oct 31, 2019
[ghstack-poisoned]
Differential Revision: [D18271855](https://our.internmc.facebook.com/intern/diff/D18271855) [ghstack-poisoned]
Differential Revision: [D18271855](https://our.internmc.facebook.com/intern/diff/D18271855) [ghstack-poisoned]
Differential Revision: [D18271855](https://our.internmc.facebook.com/intern/diff/D18271855) [ghstack-poisoned]
Differential Revision: [D18271855](https://our.internmc.facebook.com/intern/diff/D18271855) [ghstack-poisoned]
yf225
reviewed
Nov 4, 2019
Contributor
yf225
left a comment
yf225
left a comment
There was a problem hiding this comment.
@pbelevich Thanks so much for the awesome work! I have one very minor comment
| typedef c10::variant<enumtype::kNone, enumtype::kMean, enumtype::kSum> reduction_t; | ||
|
|
||
| /// Has a default value of `0`. | ||
| TORCH_ARG(float, margin) = 0; |
Contributor
There was a problem hiding this comment.
I believe we should use
Suggested change
| TORCH_ARG(float, margin) = 0; | |
| TORCH_ARG(double, margin) = 0; |
because float in Python is always 64-bit (there are a few other places in the C++ API where we use TORCH_ARG(float, ...), and we will need to change them as well :/ (Not part of this PR))
Differential Revision: [D18271855](https://our.internmc.facebook.com/intern/diff/D18271855) [ghstack-poisoned]
yf225
approved these changes
Nov 4, 2019
Contributor
|
@pbelevich merged this pull request in 69f845c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D18271855