Fix CUDA shared memory out of bound access in findPattern #28989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 1, 2019
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Nov 1, 2019
Summary: This is independent from pytorch/pytorch#28989, but when pytorch/pytorch#28989 get landed, this fixes pytorch/pytorch#28792 . Pull Request resolved: pytorch/pytorch#28995 Differential Revision: D18265797 Pulled By: soumith fbshipit-source-id: 6dd7cffd05aa65e4b366f1c40b8bda0a633e3154
ngimel
approved these changes
Nov 1, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Nov 1, 2019
Summary: This fixes pytorch/pytorch#28789 Only the first two elements of `smem` are used in this function but at the beginning, it resets all the `C10_WARP_SIZE` to 0. When the `scalar_t` is 64bit, it goes out of the total shared memory size which is `sizeof(int) * C10_WARP_SIZE`, although this does not lead to any failure in CI. Pull Request resolved: pytorch/pytorch#28989 Differential Revision: D18271598 Pulled By: ngimel fbshipit-source-id: 38cc863722509892646f719efb05e2730a7d9ae1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #28789
Only the first two elements of
smemare used in this function but at the beginning, it resets all theC10_WARP_SIZEto 0. When thescalar_tis 64bit, it goes out of the total shared memory size which issizeof(int) * C10_WARP_SIZE, although this does not lead to any failure in CI.