Make nn.Sequential iterable #28987
Closed
Make nn.Sequential iterable #28987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
[ghstack-poisoned]
We have `__iter__` defined on nn.ModuleList. Chainer's `Sequential` defines `__iter__`. This will also be helpful in modules which extend `nn.Sequential` and define a custom forward, because they can use the `for x in self` syntax that is supported in both python & TorchScript. Differential Revision: [D18402822](https://our.internmc.facebook.com/intern/diff/D18402822) [ghstack-poisoned]
added 3 commits
November 11, 2019 17:25
We have `__iter__` defined on nn.ModuleList. Chainer's `Sequential` defines `__iter__`. This will also be helpful in modules which extend `nn.Sequential` and define a custom forward, because they can use the `for x in self` syntax that is supported in both python & TorchScript. Differential Revision: [D18402822](https://our.internmc.facebook.com/intern/diff/D18402822) [ghstack-poisoned]
We have `__iter__` defined on nn.ModuleList. Chainer's `Sequential` defines `__iter__`. This will also be helpful in modules which extend `nn.Sequential` and define a custom forward, because they can use the `for x in self` syntax that is supported in both python & TorchScript. Differential Revision: [D18402822](https://our.internmc.facebook.com/intern/diff/D18402822) [ghstack-poisoned]
We have `__iter__` defined on nn.ModuleList. Chainer's `Sequential` defines `__iter__`. This will also be helpful in modules which extend `nn.Sequential` and define a custom forward, because they can use the `for x in self` syntax that is supported in both python & TorchScript. Differential Revision: [D18402822](https://our.internmc.facebook.com/intern/diff/D18402822) [ghstack-poisoned]
Contributor
xxtEchjovs44
pushed a commit
to xxtEchjovs44/pytorch
that referenced
this pull request
Jan 29, 2020
ghstack-source-id: da2c354 Pull Request resolved: pytorch/pytorch#28987
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
We have
__iter__defined on nn.ModuleList. Chainer'sSequentialdefines__iter__. This will also be helpful in modules which extendnn.Sequentialand define a custom forward, because they can use thefor x in selfsyntax that is supported in both python & TorchScript.Differential Revision: D18402822