[namedtensor] add support for {ones,zeros,full,rand,randn}_like ops #28981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds support for calling those functions on named tensors. The implementation is not the nicest: in the future we have plans to merge names into TensorOptions, at which point we don't need the extra branches that check if the tensor has names. Right now, however, these functions are very useful to have (in particular, ones_like is used by autograd to generate gradients). Test Plan: - Added tests for each of these
zou3519
added a commit
that referenced
this pull request
Oct 31, 2019
This PR adds support for calling those functions on named tensors. The implementation is not the nicest: in the future we have plans to merge names into TensorOptions, at which point we don't need the extra branches that check if the tensor has names. Right now, however, these functions are very useful to have (in particular, ones_like is used by autograd to generate gradients). Test Plan: - Added tests for each of these ghstack-source-id: b9f903b Pull Request resolved: #28981
izdeby
approved these changes
Oct 31, 2019
…_like ops" This PR adds support for calling those functions on named tensors. The implementation is not the nicest: in the future we have plans to merge names into TensorOptions, at which point we don't need the extra branches that check if the tensor has names. Right now, however, these functions are very useful to have (in particular, ones_like is used by autograd to generate gradients). Test Plan: - Added tests for each of these
zou3519
added a commit
that referenced
this pull request
Nov 1, 2019
This PR adds support for calling those functions on named tensors. The implementation is not the nicest: in the future we have plans to merge names into TensorOptions, at which point we don't need the extra branches that check if the tensor has names. Right now, however, these functions are very useful to have (in particular, ones_like is used by autograd to generate gradients). Test Plan: - Added tests for each of these ghstack-source-id: 65a94e2 Pull Request resolved: #28981
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Nov 1, 2019
Summary: Pull Request resolved: pytorch/pytorch#28981 This PR adds support for calling those functions on named tensors. The implementation is not the nicest: in the future we have plans to merge names into TensorOptions, at which point we don't need the extra branches that check if the tensor has names. Right now, however, these functions are very useful to have (in particular, ones_like is used by autograd to generate gradients). Test Plan: - Added tests for each of these Differential Revision: D18270937 Pulled By: zou3519 fbshipit-source-id: 720739ff0474449a960b81728345a4250becbfc3
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This PR adds support for calling those functions on named tensors. The
implementation is not the nicest: in the future we have plans to merge
names into TensorOptions, at which point we don't need the extra
branches that check if the tensor has names. Right now, however, these
functions are very useful to have (in particular, ones_like is used by
autograd to generate gradients).
Test Plan:
Differential Revision: D18270937