[namedtensor] support addcmul, addcdiv #28975
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TensorIterator supports propagating names so we just needed to enable them with support_named_tensor: True Test Plan: - really basic tests to test that each variant (outplace, inplace, out=) supports named tensors.
izdeby
approved these changes
Oct 31, 2019
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Nov 1, 2019
Summary: Pull Request resolved: pytorch/pytorch#28975 TensorIterator supports propagating names so we just needed to enable them with support_named_tensor: True Test Plan: - really basic tests to test that each variant (outplace, inplace, out=) supports named tensors. Differential Revision: D18252421 Pulled By: zou3519 fbshipit-source-id: ea7fb59dcf8c708b6e45d03b9c2ba27fa6b6ce98
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
TensorIterator supports propagating names so we just needed to enable
them with support_named_tensor: True
Test Plan:
supports named tensors.
Differential Revision: D18252421