Fix for torch.save not saving source files #28965
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Fixed the reference to correct object Test Plan: Verified by running the test_torch tests and a sample test case to see file getting saved with no errors or warnings import torch m = torch.nn.Linear(500, 10) torch.save(m, './test.pth') Reviewers: vincentqb Subscribers: gchauhan Tasks: Tags: Fix for torch.save not saving file Fix for torch.save not working [ghstack-poisoned]
chauhang
pushed a commit
that referenced
this pull request
Oct 31, 2019
Summary: Fixed the reference to correct object Test Plan: Verified by running the test_torch tests and a sample test case to see file getting saved with no errors or warnings import torch m = torch.nn.Linear(500, 10) torch.save(m, './test.pth') Reviewers: vincentqb Subscribers: gchauhan Tasks: Tags: Fix for torch.save not saving file Fix for torch.save not working ghstack-source-id: 5db0757 Pull Request resolved: #28965
Member
CircleCI build failures summaryAs of commit 777f11b:
Here are the reasons each build failed. This comment was automatically generated by Dr. CI. Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 1 time(s). |
Contributor
Author
|
@pytorchbot retest this please |
Summary: Fixed the reference to correct object Test Plan: Verified by running the test_torch tests and a sample test case to see file getting saved with no errors or warnings import torch m = torch.nn.Linear(500, 10) torch.save(m, './test.pth') Reviewers: vincentqb Subscribers: gchauhan Tasks: Tags: Fix for torch.save not saving file Fix for torch.save not working [ghstack-poisoned]
Summary: Fixed the reference to correct object
Test Plan:
Added new unit test test_serialization_save_warnings in test_torch
Verified by running the test_torch tests
Reviewers: vincentqb zou3519
Subscribers: gchauhan
Tasks:
Tags:
Fix for torch.save not saving file
Fix for torch.save not working
[ghstack-poisoned]
chauhang
pushed a commit
that referenced
this pull request
Oct 31, 2019
Summary: Fixed the reference to correct object, added new unit test and fixed the lint errors Test Plan: Added new unit test test_serialization_save_warnings in test_torch Verified by running the test_torch tests Reviewers: vincentqb zou3519 Subscribers: gchauhan Tasks: Tags: Fix for torch.save not saving file Fix for torch.save not working ghstack-source-id: 30db162 Pull Request resolved: #28965
Contributor
Author
|
@pytorchbot retest this please |
1 similar comment
Contributor
Author
|
@pytorchbot retest this please |
Summary: Fixed the reference to correct object
Test Plan:
Added new unit test test_serialization_save_warnings in test_torch
Verified by running the test_torch tests
Reviewers: vincentqb zou3519
Subscribers: gchauhan
Tasks:
Tags:
Fix for torch.save not saving file
Fix for torch.save not working
[ghstack-poisoned]
chauhang
pushed a commit
that referenced
this pull request
Nov 1, 2019
Summary: Fixed the reference to correct object, added new unit test and fixed the lint errors Test Plan: Added new unit test test_serialization_save_warnings in test_torch Verified by running the test_torch tests Reviewers: vincentqb zou3519 Subscribers: gchauhan Tasks: Tags: Fix for torch.save not saving file Fix for torch.save not working ghstack-source-id: 7af2cfd Pull Request resolved: #28965
Summary: Fixed the reference to correct object
Test Plan:
Added new unit test test_serialization_save_warnings in test_torch
Verified by running the test_torch tests
Reviewers: vincentqb zou3519
Subscribers: gchauhan
Tasks:
Tags:
Fix for torch.save not saving file
Fix for torch.save not working
[ghstack-poisoned]
chauhang
pushed a commit
that referenced
this pull request
Nov 1, 2019
Summary: Fixed the reference to correct object, added new unit test and fixed the lint errors Test Plan: Added new unit test test_serialization_save_warnings in test_torch Verified by running the test_torch tests Reviewers: vincentqb zou3519 Subscribers: gchauhan Tasks: Tags: Fix for torch.save not saving file Fix for torch.save not working ghstack-source-id: 8c837bd Pull Request resolved: #28965
zou3519
reviewed
Nov 4, 2019
Contributor
zou3519
left a comment
zou3519
left a comment
There was a problem hiding this comment.
This almost looks good, I had some questions
Summary: Fixed the reference to correct object
Test Plan:
Added new unit test test_serialization_save_warnings in test_torch
Verified by running the test_torch tests
Reviewers: vincentqb zou3519
Subscribers: gchauhan
Tasks:
Tags:
Fix for torch.save not saving file
Fix for torch.save not working
[ghstack-poisoned]
Summary: Fixed the reference to correct object
Test Plan:
Added new unit test test_serialization_save_warnings in test_torch
Verified by running the test_torch tests
Reviewers: vincentqb zou3519
Subscribers: gchauhan
Tasks:
Tags:
Fix for torch.save not saving file
Fix for torch.save not working
[ghstack-poisoned]
chauhang
pushed a commit
that referenced
this pull request
Nov 4, 2019
Summary: Fixed the reference to correct object, added new unit test and fixed the lint errors Test Plan: Added new unit test test_serialization_save_warnings in test_torch Verified by running the test_torch tests Reviewers: vincentqb zou3519 Subscribers: gchauhan Tasks: Tags: Fix for torch.save not saving file Fix for torch.save not working ghstack-source-id: 4be943b Pull Request resolved: #28965
zou3519
approved these changes
Nov 4, 2019
Contributor
|
This pull request has been merged in 9e314f5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary: Fixed the reference to correct object
Test Plan:
Added new unit test test_serialization_save_warnings in test_torch
Verified by running the test_torch tests
Reviewers: vincentqb zou3519
Subscribers: gchauhan
Tasks:
Tags:
Fix for torch.save not saving file
Fix for torch.save not working
Differential Revision: D18306797