[JIT] Fix aten::format regex for clang8 #28916
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Oct 30, 2019
facebook-github-bot
added
the
oncall: jit
Collaborator
Author
|
@soumith not really a revert but just an alternate implementation to fix the same issue, notice the new |
Contributor
|
@jamesr66a merged this pull request in 15deee2. |
Closed
Contributor
|
ah okay, didn't notice |
Contributor
|
@jamesr66a Adding the |
Collaborator
Author
|
@ggoossen in that case the inner atom should have |
ggoossen
added a commit
that referenced
this pull request
Nov 5, 2019
…attempt Previous attempt in #28616 didn't work in clang8 and got reverted in #28916 This one escapes the } inside the brackets, maybe that works Differential Revision: [D18324286](https://our.internmc.facebook.com/intern/diff/D18324286/) [ghstack-poisoned]
ggoossen
added a commit
that referenced
this pull request
Nov 5, 2019
…attempt Previous attempt in #28616 didn't work in clang8 and got reverted in #28916 This one escapes the } inside the brackets, maybe that works Differential Revision: [D18324286](https://our.internmc.facebook.com/intern/diff/D18324286/) ghstack-source-id: 93270628 Pull Request resolved: #29193
ggoossen
added a commit
that referenced
this pull request
Nov 5, 2019
…ns, second attempt" Previous attempt in #28616 didn't work in clang8 and got reverted in #28916 This one escapes the } inside the brackets, maybe that works Differential Revision: [D18324286](https://our.internmc.facebook.com/intern/diff/D18324286/) [ghstack-poisoned]
ggoossen
added a commit
that referenced
this pull request
Nov 5, 2019
…attempt Pull Request resolved: #29193 Previous attempt in #28616 didn't work in clang8 and got reverted in #28916 This one escapes the } inside the brackets, maybe that works ghstack-source-id: 93283014 Differential Revision: [D18324286](https://our.internmc.facebook.com/intern/diff/D18324286/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
The previous regex caused a
std::regex_errorunder clang8 complaining abouterror_brack, which is strange because the square brackets are balanced. Seems like a stdlib bug to me. So to workaround this, I've switched to the older regex with a non-greedy match in the inner atomDifferential Revision: D18232654