Fix jit outplace tracing and reapply changes to *_like operators. #28839
Conversation
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@VitalyFedyunin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
added
the
oncall: jit
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@VitalyFedyunin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@VitalyFedyunin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@VitalyFedyunin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
xla failure expected |
|
@pytorchbot retest this please |
|
Soooo... what's the fix? |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@VitalyFedyunin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
CircleCI build failures summaryAs of commit 51bc068:
Here are the reasons each build failed. This comment was automatically generated by Dr. CI. Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 1 time(s). |
…8839) Summary: Reapply reverted and fix files `gen_variable_type.py` `test_jit.py` pytorch/pytorch#27891 Cleanup testing of _like operators pytorch/pytorch#27890 Add memory format support to randn_like operator pytorch/pytorch#27889 Add memory format support to randint_like operator pytorch/pytorch#27562 Add memory format support to zeros_like operator pytorch/pytorch#27561 Add memory format support to rand_like operator pytorch/pytorch#27270 Add memory format support to ones_like operator pytorch/pytorch#27262 Add memory format support to full_like operator Pull Request resolved: pytorch/pytorch#28839 Test Plan: Imported from GitHub, without a `Test Plan:` line. buck test mode/dev //language_technology/neural_mt/os/pytorch_translate/test:test_onnx -- 'test_forced_decoder_export_vocab_reduction \(language_technology\.neural_mt\.os\.pytorch_translate\.test\.test_onnx\.TestONNX\)' Differential Revision: D18203397 Pulled By: VitalyFedyunin fbshipit-source-id: eea41cbd4c232cf5a54172b1e1b16b173798f298
|
@VitalyFedyunin merged this pull request in 4bfe2f0. |
| auto result = at::empty_like(self, options, optional_memory_format); | ||
| return result.random_(0, high, nullptr); | ||
| return native::randint(high, self.sizes(), nullptr, options); |
There was a problem hiding this comment.
@VitalyFedyunin, there are two return statements.
6 participants
Reapply reverted and fix files
gen_variable_type.pytest_jit.py#27891 Cleanup testing of _like operators
#27890 Add memory format support to randn_like operator
#27889 Add memory format support to randint_like operator
#27562 Add memory format support to zeros_like operator
#27561 Add memory format support to rand_like operator
#27270 Add memory format support to ones_like operator
#27262 Add memory format support to full_like operator