Skip to content

Conversation

@pbelevich
Copy link
Contributor

@pbelevich pbelevich commented Oct 28, 2019

Stack from ghstack:

Differential Revision: D18202435

pbelevich added a commit that referenced this pull request Oct 28, 2019
ghstack-source-id: 92f960f
Pull Request resolved: #28783
pbelevich added a commit that referenced this pull request Oct 29, 2019
ghstack-source-id: 997dc3b
Pull Request resolved: #28783
pbelevich added a commit that referenced this pull request Oct 30, 2019
ghstack-source-id: aa381f7
Pull Request resolved: #28783
pbelevich added a commit that referenced this pull request Oct 30, 2019
ghstack-source-id: c9f58b7
Pull Request resolved: #28783
pbelevich added a commit that referenced this pull request Nov 18, 2019
ghstack-source-id: 5753f03
Pull Request resolved: #28783
pbelevich added a commit that referenced this pull request Nov 19, 2019
ghstack-source-id: 410603b
Pull Request resolved: #28783
@pbelevich pbelevich requested a review from yf225 November 19, 2019 19:12
pbelevich added a commit that referenced this pull request Nov 19, 2019
ghstack-source-id: 97b33e7
Pull Request resolved: #28783
@pbelevich pbelevich requested a review from yf225 November 19, 2019 23:12
Copy link
Contributor

@yf225 yf225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbelevich Thanks so much for the awesome work!

pbelevich added a commit that referenced this pull request Nov 20, 2019
ghstack-source-id: 845fd47
Pull Request resolved: #28783
@jjlilley
Copy link

I'm seeing the following in CircleCI, re: caffe2/test/cpp/api/functional.cpp:2491

Is this related?

Nov 20 18:01:35 ERROR:sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "In file included from \u{1b}[01m\u{1b}[K/var/lib/jenkins/workspace/third_party/googletest/googletest/include/gtest/gtest.h:59:0\u{1b}[m\u{1b}[K,\n from \u{1b}[01m\u{1b}[K/var/lib/jenkins/workspace/test/cpp/api/functional.cpp:1\u{1b}[m\u{1b}[K:\n\u{1b}[01m\u{1b}[K/var/lib/jenkins/workspace/test/cpp/api/functional.cpp:\u{1b}[m\u{1b}[K In member function '\u{1b}[01m\u{1b}[Kvirtual void FunctionalTest_BCEWithLogitsLoss_Test::TestBody()\u{1b}[m\u{1b}[K':\n\u{1b}[01m\u{1b}[K/var/lib/jenkins/workspace/test/cpp/api/functional.cpp:2491:9:\u{1b}[m\u{1b}[K \u{1b}[01;31m\u{1b}[Kerror: \u{1b}[m\u{1b}[K'\u{1b}[01m\u{1b}[KBCELossFuncOptions\u{1b}[m\u{1b}[K' is not a member of '\u{1b}[01m\u{1b}[KF\u{1b}[m\u{1b}[K'\n F::BCELossFuncOptions().weight(weight)\n\u{1b}[01;32m\u{1b}[K ^\u{1b}[m\u{1b}[K\n\u{1b}[01m\u{1b}[K/var/lib/jenkins/workspace/test/cpp/api/functional.cpp:2508:9:\u{1b}[m\u{1b}[K \u{1b}[01;31m\u{1b}[Kerror: \u{1b}[m\u{1b}[K'\u{1b}[01m\u{1b}[KBCELossFuncOptions\u{1b}[m\u{1b}[K' is not a member of '\u{1b}[01m\u{1b}[KF\u{1b}[m\u{1b}[K'\n F::BCELossFuncOptions().reduction(torch::kNone)\n\u{1b}[01;32m\u{1b}[K ^\u{1b}[m\u{1b}[K\n\u{1b}[01m\u{1b}[K/var/lib/jenkins/workspace/test/cpp/api/functional.cpp:2518:9:\u{1b}[m\u{1b}[K \u{1b}[01;31m\u{1b}[Kerror: \u{1b}[m\u{1b}[K'\u{1b}[01m\u{1b}[KBCELossFuncOptions\u{1b}[m\u{1b}[K' is not a member of '\u{1b}[01m\u{1b}[KF\u{1b}[m\u{1b}[K'\n F::BCELossFuncOptions().weight(weight)\n\u{1b}[01;32m\u{1b}[K ^\u{1b}[m\u{1b}[K\n" }

@yf225
Copy link
Contributor

yf225 commented Nov 20, 2019

@jjlilley Is it related to #30146 and I just reverted that PR. It should be green on master now :D

@facebook-github-bot
Copy link
Contributor

@pbelevich merged this pull request in f8e7f3f.

@facebook-github-bot facebook-github-bot deleted the gh/pbelevich/49/head branch November 23, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants