-
Notifications
You must be signed in to change notification settings - Fork 26.3k
C++ API parity: BCEWithLogitsLoss #28783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Differential Revision: [D18202435](https://our.internmc.facebook.com/intern/diff/D18202435) [ghstack-poisoned]
Differential Revision: [D18202435](https://our.internmc.facebook.com/intern/diff/D18202435) [ghstack-poisoned]
Differential Revision: [D18202435](https://our.internmc.facebook.com/intern/diff/D18202435) [ghstack-poisoned]
Differential Revision: [D18202435](https://our.internmc.facebook.com/intern/diff/D18202435) [ghstack-poisoned]
Differential Revision: [D18202435](https://our.internmc.facebook.com/intern/diff/D18202435) [ghstack-poisoned]
Differential Revision: [D18202435](https://our.internmc.facebook.com/intern/diff/D18202435) [ghstack-poisoned]
Differential Revision: [D18202435](https://our.internmc.facebook.com/intern/diff/D18202435) [ghstack-poisoned]
Differential Revision: [D18202435](https://our.internmc.facebook.com/intern/diff/D18202435) [ghstack-poisoned]
Differential Revision: [D18202435](https://our.internmc.facebook.com/intern/diff/D18202435) [ghstack-poisoned]
Differential Revision: [D18202435](https://our.internmc.facebook.com/intern/diff/D18202435) [ghstack-poisoned]
Differential Revision: [D18202435](https://our.internmc.facebook.com/intern/diff/D18202435) [ghstack-poisoned]
Differential Revision: [D18202435](https://our.internmc.facebook.com/intern/diff/D18202435) [ghstack-poisoned]
Differential Revision: [D18202435](https://our.internmc.facebook.com/intern/diff/D18202435) [ghstack-poisoned]
Differential Revision: [D18202435](https://our.internmc.facebook.com/intern/diff/D18202435) [ghstack-poisoned]
Differential Revision: [D18202435](https://our.internmc.facebook.com/intern/diff/D18202435) [ghstack-poisoned]
yf225
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pbelevich Thanks so much for the awesome work!
Differential Revision: [D18202435](https://our.internmc.facebook.com/intern/diff/D18202435) [ghstack-poisoned]
|
I'm seeing the following in CircleCI, re: caffe2/test/cpp/api/functional.cpp:2491 Is this related? Nov 20 18:01:35 ERROR:sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "In file included from \u{1b}[01m\u{1b}[K/var/lib/jenkins/workspace/third_party/googletest/googletest/include/gtest/gtest.h:59:0\u{1b}[m\u{1b}[K,\n from \u{1b}[01m\u{1b}[K/var/lib/jenkins/workspace/test/cpp/api/functional.cpp:1\u{1b}[m\u{1b}[K:\n\u{1b}[01m\u{1b}[K/var/lib/jenkins/workspace/test/cpp/api/functional.cpp:\u{1b}[m\u{1b}[K In member function '\u{1b}[01m\u{1b}[Kvirtual void FunctionalTest_BCEWithLogitsLoss_Test::TestBody()\u{1b}[m\u{1b}[K':\n\u{1b}[01m\u{1b}[K/var/lib/jenkins/workspace/test/cpp/api/functional.cpp:2491:9:\u{1b}[m\u{1b}[K \u{1b}[01;31m\u{1b}[Kerror: \u{1b}[m\u{1b}[K'\u{1b}[01m\u{1b}[KBCELossFuncOptions\u{1b}[m\u{1b}[K' is not a member of '\u{1b}[01m\u{1b}[KF\u{1b}[m\u{1b}[K'\n F::BCELossFuncOptions().weight(weight)\n\u{1b}[01;32m\u{1b}[K ^\u{1b}[m\u{1b}[K\n\u{1b}[01m\u{1b}[K/var/lib/jenkins/workspace/test/cpp/api/functional.cpp:2508:9:\u{1b}[m\u{1b}[K \u{1b}[01;31m\u{1b}[Kerror: \u{1b}[m\u{1b}[K'\u{1b}[01m\u{1b}[KBCELossFuncOptions\u{1b}[m\u{1b}[K' is not a member of '\u{1b}[01m\u{1b}[KF\u{1b}[m\u{1b}[K'\n F::BCELossFuncOptions().reduction(torch::kNone)\n\u{1b}[01;32m\u{1b}[K ^\u{1b}[m\u{1b}[K\n\u{1b}[01m\u{1b}[K/var/lib/jenkins/workspace/test/cpp/api/functional.cpp:2518:9:\u{1b}[m\u{1b}[K \u{1b}[01;31m\u{1b}[Kerror: \u{1b}[m\u{1b}[K'\u{1b}[01m\u{1b}[KBCELossFuncOptions\u{1b}[m\u{1b}[K' is not a member of '\u{1b}[01m\u{1b}[KF\u{1b}[m\u{1b}[K'\n F::BCELossFuncOptions().weight(weight)\n\u{1b}[01;32m\u{1b}[K ^\u{1b}[m\u{1b}[K\n" } |
|
@pbelevich merged this pull request in f8e7f3f. |
Stack from ghstack:
Differential Revision: D18202435