Skip to content

Add ONNX Export Support for torch.scalar_tensor #28713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lara-hdr wants to merge 4 commits into from
Closed

Add ONNX Export Support for torch.scalar_tensor #28713

lara-hdr wants to merge 4 commits into from

Conversation

@lara-hdr
Copy link
Contributor

@lara-hdr lara-hdr commented Oct 25, 2019 •
edited
Loading

Support exporting torch.scalar_tensor() to ONNX.
This will allow making operations on dynamic scalars (like x.size(dim) where x is a tensor of dynamic shape) and exporting them to ONNX.

This is a dummy example of operations that could not be exported dynamically before this PR:

size_x = x.size(0)
size_y = y.size(0)
size_x_y_static = torch.tensor([size_x , size_y])  # size_x_y_static is traced as constant

size_x = torch.scalar_tensor(size_x).unsqueeze(0)
size_y = torch.scalar_tensor(size_y).unsqueeze(0)
size_x_y_dynamic = torch.cat((size_x , size_y))  # size_x_y_dynamic is dynamic and depends on x and y's size

@lara-hdr lara-hdr requested a review from BowenBao November 6, 2019 22:22
BowenBao
BowenBao reviewed Nov 6, 2019
View reviewed changes
BowenBao
BowenBao approved these changes Nov 11, 2019
View reviewed changes
Copy link
Collaborator

@BowenBao BowenBao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

facebook-github-bot
facebook-github-bot reviewed Nov 11, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

houseroad
houseroad approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 12, 2019

@houseroad merged this pull request in 8b53515.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@BowenBao BowenBao BowenBao approved these changes

@houseroad houseroad houseroad approved these changes

@spandantiwari spandantiwari Awaiting requested review from spandantiwari

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lara-hdr @facebook-github-bot @BowenBao @houseroad @mruberry